Skip to content

Edited user and workspace tab to only display the name for accessibility #184530#184627

Merged
rzhao271 merged 10 commits into
microsoft:mainfrom
cadinsl:adjust_tooltip_user_workspace_settings
Jun 13, 2023
Merged

Edited user and workspace tab to only display the name for accessibility #184530#184627
rzhao271 merged 10 commits into
microsoft:mainfrom
cadinsl:adjust_tooltip_user_workspace_settings

Conversation

@cadinsl

@cadinsl cadinsl commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Fix #184530
When you hover the mouse over user or workspace in settings it will only show again user or workspace instead of the path to the settings.
This allows for accessibility features such as NVDA for windows and macOS VoiceOver to not be as verbose and confuse the user.

To Test: Go to settings and hover the mouse over user and workspace in the tab section for scope switching.

Comment thread src/vs/workbench/contrib/preferences/browser/preferencesWidgets.ts Outdated
Comment thread src/vs/workbench/contrib/preferences/browser/preferencesWidgets.ts
@rzhao271 rzhao271 added this to the June 2023 milestone Jun 8, 2023
Comment thread src/vs/workbench/contrib/preferences/browser/preferencesWidgets.ts
@rzhao271

Copy link
Copy Markdown
Collaborator

Also, the build failed. Please try running yarn && yarn watch locally and then fixing the build errors.

@cadinsl

cadinsl commented Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@rzhao271 rzhao271 requested a review from meganrogge June 13, 2023 20:43

@meganrogge meganrogge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@rzhao271 rzhao271 merged commit 34911a2 into microsoft:main Jun 13, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings scope switcher is too verbose when using a screenreader

3 participants