fix #179337 Task icon for terminal tab entry does not update with task label when terminal is reused#179596
Merged
meganrogge merged 1 commit intomicrosoft:mainfrom Apr 13, 2023
Conversation
… with task label when terminal is reused
|
Nice find @weartist ! Looks like that's the same sort of calls that are used to correctly restore and resolve this icon elsewhere: |
Contributor
Author
haha but one thing I'm not sure about is whether _onIconChanged needs to be called, because I only added the update to the initialization case, and I'm not sure if this call is redundant |
meganrogge
approved these changes
Apr 11, 2023
sandy081
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #179337