Correctly resolve the icon asap when defaultProfile is null#151643
Merged
Correctly resolve the icon asap when defaultProfile is null#151643
Conversation
When the defaultProfile is null we don't actually know what the default profile is until the process has been created, this is because it needs a round trip to the pty host. This change fixes the _icon prop updating and icon changed event firing. Fixes #151639
meganrogge
approved these changes
Jun 9, 2022
Member
|
@Tyriar related? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the defaultProfile is null we don't actually know what the default
profile is until the process has been created, this is because it needs a
round trip to the pty host. This change fixes the _icon prop updating and
icon changed event firing.
Fixes #151639