Invert term find widget relationship such that it's registered on an instance, not owned by it#175785
Merged
Conversation
Tyriar
added a commit
that referenced
this pull request
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
TerminalFindWidgetwas owned and managed by the terminal instance, the downside of this is that terminal find code is peppered throughout terminalInstance.ts, terminal.ts, terminalActions.ts, etc. This PR inverts the relationship and isolates all the find code (outside of xterm/XtermTerminal) in a find/ folder that has its own contribution file that is imported by the mainterminal.contribution.Fixes #175781