Skip to content

Add list of strings option to editor.fontFamily#164289

Merged
alexdima merged 4 commits intomicrosoft:mainfrom
astrolemonade:main
Nov 18, 2022
Merged

Add list of strings option to editor.fontFamily#164289
alexdima merged 4 commits intomicrosoft:mainfrom
astrolemonade:main

Conversation

@astrolemonade
Copy link
Contributor

This is for #164275

This allows users to use a list of strings instead of single string for editor.fontFamily.

@astrolemonade
Copy link
Contributor Author

astrolemonade commented Oct 21, 2022

I tried to add support for terminal.integrated.fontFamily too but it seems like it does not provide a way to transform the value before validation. If you have any ideas on how to get around that, let me know.

@astrolemonade
Copy link
Contributor Author

@microsoft-github-policy-service agree

@alexdima alexdima self-requested a review November 16, 2022 13:33
@alexdima alexdima added this to the November 2022 milestone Nov 16, 2022
@alexdima alexdima merged commit 2212e36 into microsoft:main Nov 18, 2022
@alexdima
Copy link
Member

Thank you!

@lakshits11
Copy link

Hy can we do something for UI...some people dont want to go to settings.json to change their font, they(including me) always have habit of pressing ctrl+, and changing font directly from UI. So what I propose is to do something like this for UI:

You can do like this extension clangd has done:

We can add font names in a list and can provide checkboxes in front of each item to comment/uncomment the font name.

@alexdima
Copy link
Member

@lakshits11 I agree and thanks for raising this. The font family is a very often configured setting and it must be configurable from the settings UI.

@lakshits11
Copy link

@alexdima @cmarincia Also I think theres no sense in commenting and uncommenting the font since only one font is usable in editor at a time so user can change it manually whenever he wants(if we consider the prev format)

Also suppose think you have 10 different font names in ur list, and now when u want to use a font u would have to comment all other fonts and uncomment the one u want to use. Isn't it gonna be time consuming? Please suggest ur side too.

rzhao271 added a commit that referenced this pull request Nov 28, 2022
rzhao271 added a commit that referenced this pull request Nov 28, 2022
@astrolemonade
Copy link
Contributor Author

astrolemonade commented Dec 2, 2022

Commenting those families is much more easier than selecting the list of comma separated fonts and moving it to the end of editor.fontFamily.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants