Add option to not pass --no-ignore-parent to rg#140022
Merged
roblourens merged 1 commit intomicrosoft:mainfrom Jan 4, 2022
samestep:use-parent-ignore-files
Merged
Add option to not pass --no-ignore-parent to rg#140022roblourens merged 1 commit intomicrosoft:mainfrom samestep:use-parent-ignore-files
roblourens merged 1 commit intomicrosoft:mainfrom
samestep:use-parent-ignore-files
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roblourens This PR fixes #118229. You can test it using these steps:
foo/, run the following command:foo/.gitignore:baz.txtfoo/bar/baz.txt:foo/bar/.baz: the filebaz.txtshould appear.qux: its appearance inbaz.txtshould appear.baz.txtin VS Code in step 7 or 8, run Go to File... again and click the "X" next tobaz.txt(it would say "recently opened" in that case).I wrote this by piggybacking off of #59717: I searched for the string
GlobalIgnoreFilesin the codebase and added similar code forParentIgnoreFilesalongside each occurrence I found. Please let me know if I missed anything, or if I should add any automated tests to accompany the code changes.