-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Closed
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderssearchSearch widget and operation issuesSearch widget and operation issuesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
Currently VSCode uses ripgrep's --no-ignore-parent option. This is inconvenient and can significantly slow down search. E.g. if we consider following scenario:
Monorepo with following structure (various folders with same name excluded by parent .gitignore)
.gitignore
backend/
- project1
- project2
- etc.
frontend/
-project1
-etc.
If user opens project1 folder in vscode, currently parent ignore settings will not be respected. It this can produce a lot of unexpected results and slows search performance.
| args.push('--no-ignore-parent'); |
| args.push('--no-ignore-parent'); |
Proposal is to add an option to use search without --no-ignore-parent.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderssearchSearch widget and operation issuesSearch widget and operation issuesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded