Second attempt at a badges API#139229
Second attempt at a badges API#139229matthewjamesadam wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
|
| * @param viewId Id of the view contributed using the extension point `views`. | ||
| * @param activityProvider A {@link ActivityProvider} that provides activity state for the view | ||
| */ | ||
| export function registerActivityProvider(viewId: string, activityProvider: ActivityProvider): Disposable; |
There was a problem hiding this comment.
It's unclear to me if the thing you would register the activity provider for would be the ID of the view, or the view container. I believe you can contribute activity information for both, but I'm not sure if an extension API should support both or not.
|
@matthewjamesadam thank you for the PRs! Just an heads up that our API process can be a long: https://github.com/Microsoft/vscode/wiki/Extension-API-process I will bring your proposals to our next team API meeting and let you know the feedback in the PRs. |
|
Thank you @alexr00 , I appreciate that there is a process for changing the extension API and that it might take awhile. Thanks for taking this to the API meeting, let me know if there is any other way I can help. |
|
Of the two API proposals, the other is closer to what we're looking for in badges! I've left my feedback there: #139225 (comment). Closing in favor of the other proposal. |
|
Thanks for the feedback @alexr00 ! |
This is a WIP for getting feedback for #62783
Alternative API is here: #139225