Skip to content

Use readonly #12732#13863

Closed
Ikuyadeu wants to merge 154 commits intomicrosoft:masterfrom
Ikuyadeu:use_readonly
Closed

Use readonly #12732#13863
Ikuyadeu wants to merge 154 commits intomicrosoft:masterfrom
Ikuyadeu:use_readonly

Conversation

@Ikuyadeu
Copy link
Copy Markdown
Contributor

Adopted readonly in vscode.d.ts

@mention-bot
Copy link
Copy Markdown

@Ikuyadeu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma, @jrieken and @Tyriar to be potential reviewers.

@jrieken
Copy link
Copy Markdown
Member

jrieken commented Oct 17, 2016

We cannot merge that yet

  • we use typedoc to generate the extension API page and that isn't fit for TypeScript 2.0 yet
  • it's unsure how readonly-ness should be expressed for objects we have created vs objects consumer create, e.g TextEditorOptions cannot be modified by setting a value ala options.lineNumbers = value but when creating a new objects they can

@Ikuyadeu
Copy link
Copy Markdown
Contributor Author

Thank you.
So, I should close this PR once, or wait until typedoc to version up?
Can I be of any help for it?

sandy081 and others added 8 commits December 15, 2016 18:00
- Display the icon in the gutter area
- Show sub menu if there are more actions
- Highlight line when copied
- Highlight line when hovered on aciton
- Delayed display of icon on mouse move
-  Improve highlighting when hovered on action
- Improve highlighting when updating setting
- Improve hover text of action
- Do not bail out if settings has errors (Ignore invalid settings)
- Fix mouse over on edit icon
@jrieken jrieken added this to the January 2017 milestone Dec 27, 2016
@jrieken
Copy link
Copy Markdown
Member

jrieken commented Dec 27, 2016

We are ready for this and want it for Jan

@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Dec 27, 2016

Can the @readonly comment annotations be removed now?

@Ikuyadeu
Copy link
Copy Markdown
Contributor Author

Ikuyadeu commented Dec 28, 2016

@jrieken
Copy link
Copy Markdown
Member

jrieken commented Dec 28, 2016

re #13863 (comment) I wanna first check how the doc generation tool handles the native readonly flag.

re #13863 (comment) Thanks. Didn't know that

@Ikuyadeu Ikuyadeu closed this Jan 7, 2017
@Ikuyadeu
Copy link
Copy Markdown
Contributor Author

Ikuyadeu commented Jan 7, 2017

@jrieken Sorry, I missed

@Ikuyadeu
Copy link
Copy Markdown
Contributor Author

Ikuyadeu commented Jan 7, 2017

Reopened PR in #18251

jrieken added a commit that referenced this pull request Jan 9, 2017
@Ikuyadeu Ikuyadeu deleted the use_readonly branch January 10, 2017 02:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.