RPM: Don't generate build_id links #116105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Fantastic, thanks for this! 🙏 |
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Feb 9, 2021
* Don't generate build_id links * add comment explaining change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #116100 and #115856
By default,
rpmbuildgenerates build_id links, which are debugging symbols for binaries included in a package. This causes problems for users trying to install two versions of VS Code at once (eg stable + insiders) which share the same Electron binary, as the debugging symbols conflict with each other.As a workaround, this PR disables generating build_id links to prevent conflicting files between different versions of VS Code.
See also: