-
Notifications
You must be signed in to change notification settings - Fork 38.9k
When in centered layout, show inline diff view also in centered layout #97165
Copy link
Copy link
Closed
Labels
diff-editorDiff editor issuesDiff editor issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
Version: 1.45.0-insider
Commit: d69a79b73808559a91206d73d7717ff5f798f23c
Date: 2020-05-06T08:25:01.764Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0
When in centered layout, opening a diff view in inline mode (as opposed to side-by-side mode) should not force the diff view into full editor width as it does for side-by-side diff views.
This is a follow-up from #94696 where we discussed this might be a bug. 🤔
Steps to Reproduce:
- Toggle centered layout
- Open a diff view in inline mode
- Observe diff view now occupies full editor width (as if centered layout was not enabled)
Demo:
Does this issue occur when all extensions are disabled?: Yes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
diff-editorDiff editor issuesDiff editor issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
