Quit centered layout mode when opening a diff editor. Fix #94574.#94696
Merged
Quit centered layout mode when opening a diff editor. Fix #94574.#94696
Conversation
Collaborator
|
@rebornix thanks a lot for this PR. It is good work. However I see some unrelated changes in the |
Member
Author
|
@isidorn oops, I pushed to the wrong branch. I'll remove the find related code and then merge. |
f781016 to
77d6451
Compare
Contributor
|
Having the diff editor exit centered mode was a good idea, although I would have preferred it only did so in side-by-side diff view mode. When I open the inline diff which would fit into a single tab group it feels weird to see it suddenly span the whole editor width. Just a quick feedback. 👍 Or... is that a bug? 🤔 |
Collaborator
|
@robertrossmann makes sense. Yeah please file a bug and we might get @rebornix to look into it :) |
Member
Author
|
It's a bug or polish item (as I'm aware of it ;) ), feel free to file an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #94574