-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Closed
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.insiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiders
Milestone
Description
/common/ code should not import /browser/ code. By convention vs/workbench/workbench.web.api is considered to be /browser/. Please consider extracting IWorkbenchConstructionOptions to /common/, or moving environmentService.ts to /browser/, or maybe moving IWorkbenchEnvironmentService.options to another service.
| // TODO@layers | |
| // eslint-disable-next-line code-import-patterns | |
| import type { IWorkbenchConstructionOptions as IWorkbenchOptions } from 'vs/workbench/workbench.web.api'; |
This import came in via 92dafb3 .
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.insiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiders