We do have a rule for platform/*/browser at

Lines 252 to 261 in 579e0a3

    
           { 
        
           	"target": "**/vs/platform/*/browser/**", 
        
           	"restrictions": [ 
        
           		"vs/nls", 
        
           		"vs/css!./**/*", 
        
           		"**/vs/base/{common,browser}/**", 
        
           		"**/vs/base/parts/*/{common,browser}/**", 
        
           		"**/vs/platform/*/{common,browser}/**" 
        
           	] 
        
           },

But we don't have a rule for platform/browser (in this case it was src/vs/platform/browser/contextScopedHistoryWidget.ts). I think the idea was that each service in platform should get its own subfolder, but in the meantime we have a top level platform/browser 🤷 .

I will push a change to show an error if there are no rules for a file. Each file in our source tree should end up matching a rule from code-import-patterns.

	{
	"target": "*/vs/platform//browser/**",
	"restrictions": [
	"vs/nls",
	"vs/css!./*/",
	"/vs/base/{common,browser}/",
	"*/vs/base/parts//{common,browser}/**",
	"*/vs/platform//{common,browser}/**"
	]
	},

Review eslint code import patterns rules #140857

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions