Skip to content

Preserve assertion when fixing VSTHRD103#338

Merged
AArnott merged 2 commits intomicrosoft:v15.8from
sharwell:preserve-assertion
Aug 7, 2018
Merged

Preserve assertion when fixing VSTHRD103#338
AArnott merged 2 commits intomicrosoft:v15.8from
sharwell:preserve-assertion

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented Aug 5, 2018

Fixes #328
Fixes #329

@sharwell sharwell changed the title Preserve assertion when fixing VSTHRD103 [In progress] Preserve assertion when fixing VSTHRD103 Aug 5, 2018
@sharwell sharwell changed the title [In progress] Preserve assertion when fixing VSTHRD103 Preserve assertion when fixing VSTHRD103 Aug 5, 2018
@AArnott
Copy link
Copy Markdown
Member

AArnott commented Aug 7, 2018

These look like important fixes. Can you rebase the PR to target v15.8?

@sharwell sharwell changed the base branch from master to v15.8 August 7, 2018 15:08
@sharwell sharwell force-pushed the preserve-assertion branch from 1b140ff to ad635ee Compare August 7, 2018 15:08
@sharwell
Copy link
Copy Markdown
Contributor Author

sharwell commented Aug 7, 2018

@AArnott rebase and retarget complete

Copy link
Copy Markdown
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AArnott AArnott merged commit 57e6bee into microsoft:v15.8 Aug 7, 2018
@AArnott AArnott added this to the v15.8 milestone Aug 7, 2018
@sharwell sharwell deleted the preserve-assertion branch August 7, 2018 16:38
AArnott pushed a commit that referenced this pull request Jan 12, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants