Add additional logging and defenses to artifacts use.#947
Merged
BillyONeal merged 4 commits intomicrosoft:mainfrom Mar 13, 2023
Merged
Add additional logging and defenses to artifacts use.#947BillyONeal merged 4 commits intomicrosoft:mainfrom
BillyONeal merged 4 commits intomicrosoft:mainfrom
Conversation
Hopefully helps run down what's happening in microsoft/vcpkg#30051
dan-shaw
approved these changes
Mar 10, 2023
|
|
||
| if (!ec) | ||
| auto result_hash = hasher.get_hash(); | ||
| if (Debug::g_debugging) |
Contributor
There was a problem hiding this comment.
I don't think we need this if statement, Debug::print should already check if we are in debug mode.
Member
Author
There was a problem hiding this comment.
This was done to avoid the cost of the format but that's premature, yes.
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Mar 28, 2023
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Mar 28, 2023
BillyONeal
added a commit
that referenced
this pull request
Mar 28, 2023
* Fix setting VCPKG_ROOT broken in #947 * Update scripts sha and add release checklist for VS.
Contributor
|
I don't know if this was intentional but this changed the output from to which is also shown to use users in case of a hash mismatch. |
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Mar 29, 2023
BillyONeal
added a commit
that referenced
this pull request
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix microsoft/vcpkg#26172
Helps debug microsoft/vcpkg#30051