post build check: Always allow .pc files in lib/pkgconfig and debug/lib/pkgconfig#906
Merged
BillyONeal merged 1 commit intomicrosoft:mainfrom Feb 15, 2023
Conversation
Contributor
|
Maybe emit a msg that it could be moved to share/pkgconfig ? |
Contributor
Better not. Safe the noise when the file is in a valid location. |
Contributor
Maybe only in |
Member
I don't think there's much value in debug only post build checks. Particularly when you can just find them with grep et al. later if you want. I'm going to merge this because it fixes tool release blockers. Thanks! |
Contributor
I cannot grep through files I dont have, however I can make CI run in debug mode ;) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vcpkg#29661