Skip to content

ci: Don't pull in ports that causes cascades#856

Merged
BillyONeal merged 2 commits intomicrosoft:mainfrom
autoantwort:feature/dont-pull-in-ports-that-causes-cascades
Feb 14, 2023
Merged

ci: Don't pull in ports that causes cascades#856
BillyONeal merged 2 commits intomicrosoft:mainfrom
autoantwort:feature/dont-pull-in-ports-that-causes-cascades

Conversation

@autoantwort
Copy link
Copy Markdown
Contributor

@autoantwort autoantwort commented Jan 12, 2023 •
edited
Loading

Same goal as #846 but it works in more situations. Fixes microsoft/vcpkg#23490

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Jan 12, 2023

Isn't microsoft/vcpkg#23490 fixed by #846 for the x64-windows to x86 cross-builds? That PR will already remove the unsupported x86 qtwebengine from the initial list of ports, so it will no longer pull in x64 qtwebengine.

If the focus in on additional output, I would prefer to see this implemented on top of my PR.

@autoantwort
Copy link
Copy Markdown
Contributor Author

autoantwort commented Jan 12, 2023 •
edited
Loading

Isn't microsoft/vcpkg#23490 fixed by #846 for the x64-windows to x86 cross-builds? That PR will already remove the unsupported x86 qtwebengine from the initial list of ports, so it will no longer pull in x64 qtwebengine.

No. It still pulls in x64 qtwebengine because the qt port does support x86 and depends on qtwebengine and then all dependencies of x86 qtwebengine gets pulled in (also also x64 qtwebengine)

@autoantwort autoantwort mentioned this pull request Jan 12, 2023
Closed
BillyONeal
BillyONeal approved these changes Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. Thanks for the fix!

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Feb 8, 2023

@ras0219-msft Do you want a look at this?

@BillyONeal BillyONeal merged commit 2f3a6b4 into microsoft:main Feb 14, 2023
@autoantwort autoantwort deleted the feature/dont-pull-in-ports-that-causes-cascades branch February 14, 2023 21:19
BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this pull request Feb 14, 2023
@BillyONeal
Fix stealth merge conflict
71b6556 
Between microsoft#856 and microsoft#899
@BillyONeal BillyONeal mentioned this pull request Feb 14, 2023
Merged
BillyONeal added a commit that referenced this pull request Feb 15, 2023
@BillyONeal
Fix stealth merge conflict (#904)
e9487f1 
* Fix stealth merge conflict

Between #856 and #899

* Oops, one more e2e test format SNAFU
@StarGate-One StarGate-One mentioned this pull request Feb 15, 2023
Closed
@dg0yt dg0yt mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[vcpkg-tool] Supports expressions do not remove host port dependencies from the graph in CI

3 participants

@autoantwort @dg0yt @BillyONeal