Merged
Conversation
ff3b271 to
ccd77dc
Compare
strega-nil-ms
suggested changes
Dec 29, 2021
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
There are some clear (minor) changes needed, but I want someone else to take a look and see if we want to do this.
strega-nil-ms
approved these changes
Dec 29, 2021
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
nevermind; I am so annoyed that this is the best way to get a string representation of a thread ID.
Collaborator
|
I merged #305 since it seems obviously positive. I am less convinced about arbitrarily retrying: child processes are not guaranteed to be idempotent. If we want to implement a retry around "unzip" specifically on mac, I think that would be reasonable. It should not be implemented for all processes though. |
ras0219-msft
requested changes
Jan 7, 2022
Collaborator
ras0219-msft
left a comment
There was a problem hiding this comment.
See above comment.
ccd77dc to
23535ef
Compare
…fails with code 127
a86c952 to
ecacaec
Compare
…ils with code 127" This reverts commit 23535ef.
ras0219-msft
approved these changes
Jan 27, 2022
Collaborator
|
Thanks, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close microsoft/vcpkg#21905 bullet point 1.
Code 127 normally means
command not found, but that does not really makes sense here. Sometimes (not often)unzipreturns 127 and sometimes not, when you retry it the return code is 0. I have no idea what the problem could be, but this implements a workaround by retrying the command once on mac when the return code is 127.