cmd_execute_and_stream_data: Determine right exit codes#305
Merged
ras0219-msft merged 1 commit intomicrosoft:mainfrom Jan 7, 2022
Merged
cmd_execute_and_stream_data: Determine right exit codes#305ras0219-msft merged 1 commit intomicrosoft:mainfrom
ras0219-msft merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
And include the thread prefix in the output so that you can see which debug messages belongs together when multiple threads are used to unpack the binary cache |
dcfe0ca to
23e1d11
Compare
Collaborator
|
This seems trivially positive to me, thanks for catching this pretty serious bug! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://linux.die.net/man/3/pclose:
And from https://linux.die.net/man/2/wait4:
And from https://linux.die.net/man/2/waitpid: