[x-download] teach to not need a sha512#142
Merged
BillyONeal merged 5 commits intomicrosoft:mainfrom Jul 30, 2021
Merged
Conversation
BillyONeal
reviewed
Jul 29, 2021
ras0219-msft
approved these changes
Jul 29, 2021
Collaborator
ras0219-msft
left a comment
There was a problem hiding this comment.
Approve, though I don't especially like significant ceremony and boilerplate of struct Sha512Check compared to a flat Optional<std::string>.
Contributor
|
@ras0219-msft I'm okay either way; @BillyONeal which would you rather? |
f4e0200 to
9195a3a
Compare
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Jul 29, 2021
BillyONeal
approved these changes
Jul 30, 2021
Member
|
Thanks! |
ras0219-msft
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.