[blender] Add ci-vcpkg-blender ci test port for windows#51143
Conversation
0641dae to
c0385f1
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
c0385f1 to
5795743
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
5795743 to
bb66a00
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
AI review: vcpkg CI Failure ReportBuild: #130054 Summary
Total: 3 failed jobs, 1 unique regression ( 🔴 Regression:
|
dg0yt
left a comment
There was a problem hiding this comment.
Cursory review.
I'm glad that the opencv4 changes are much smaller than in the previous PR.
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DPKG_CONFIG_USE_STATIC_LIBS=ON | ||
| -DCURRENT_INSTALLED_DIR=${CURRENT_INSTALLED_DIR} |
There was a problem hiding this comment.
I probably wouldn't want to introduce this script mode variable name into the project mode.
I am also concerned that this is used in another way which mixes different Windows runtimes.
There was a problem hiding this comment.
It should change when I change to vcpkg_find_acquire_program(PKGCONFIG). Isn't it?
There was a problem hiding this comment.
Thanks, fixed.
I removed the project-mode use of CURRENT_INSTALLED_DIR. The patch now uses a purpose-specific VCPKG_BLENDER_RUNTIME_DIR variable only for Blender's build-time tool PATH.
The portfile passes it config-specifically:
- release uses
${CURRENT_INSTALLED_DIR}/bin - debug uses
${CURRENT_INSTALLED_DIR}/debug/bin
So Blender no longer sees the vcpkg script-mode variable name, and the PATH no longer mixes debug and release runtime directories.
Thank you. |
1fe3d79 to
4c82a42
Compare
Use VCPKG_HOST_PATH_SEPARATOR instead of manually selecting the host path separator, acquire pkg-config with vcpkg_find_acquire_program(PKGCONFIG), and switch copyright installation to vcpkg_install_copyright. Also remove the now-unneeded host pkgconf dependency from the test port manifest.
Replace the project-mode use of CURRENT_INSTALLED_DIR with a Blender-specific runtime directory option. Pass the release and debug vcpkg bin directories separately through VCPKG_BLENDER_RUNTIME_DIR so build-time Blender tools can find their DLLs without mixing Windows runtimes.
|
@vicroms |
BillyONeal
left a comment
There was a problem hiding this comment.
I'm not sure how I feel about this. On the one hand, it's good to have something that is a real user of a bunch of these components available to test things, because it's clearly going to catch / has caught real issues.
On the other hand, this is a substantial amount of product code patches that are likely to rot over time we would be signing up to maintain, for something that we aren't even really shipping to our customers.
How long does this thing take to build? Unfortunately the most recent available run did not build it so I can't see there.
On balance I think we should probably merge it with the caveat that we will not hesitate to remove it if it creates substantial problems for someone trying to update any of the dependencies in the future. But I want to bring it up with the team.
BillyONeal
left a comment
There was a problem hiding this comment.
And now I see opencv4 blowing up in other PRs from stuff this one fixed I think that argues to just merge it.
|
This is not properly reviewed. |
[blender] Add ci-vcpkg-blender ci test port for windows