Conversation
JavierMatosD
left a comment
There was a problem hiding this comment.
Is this port vendoring pcre and ryu?
In 2023 in microsoft#32645 we told Bloomberg folks if the vendored dependency problems were not fixed after "some time" we would have to move forward with deindexing. It's been 3 years which seems like "some time". (This was brought to our attention again in microsoft#50283 ) I believe BDE was not tested on any platforms and the only reason it wasn't =skip everywhere is that the supports clause excluded some. We would be happy to return BDE if someone wants to reintroduce it with vendored/conflicting library dependencies removed.
| -DCMAKE_CXX_STANDARD_REQUIRED=ON | ||
| -DCMAKE_CXX_EXTENSIONS=OFF | ||
| -DBBS_BUILD_SYSTEM=1 | ||
| "-DBdeBuildSystem_DIR:PATH=${TOOLS_PATH}/BdeBuildSystem" |
There was a problem hiding this comment.
| "-DBdeBuildSystem_DIR:PATH=${TOOLS_PATH}/BdeBuildSystem" | |
| -DBDE_USE_EXTERNAL_PCRE2 |
ports/bde/portfile.cmake
Outdated
| vcpkg_cmake_install() | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||
| list(APPEND SUBPACKAGES "ryu" "inteldfp" "pcre2" "s_baltst" "bsl" "bdl" "bal") | ||
| list(APPEND SUBPACKAGES "inteldfp" "pcre2" "s_baltst" "bsl" "bbryu" "bdl" "bbl" "bal") |
There was a problem hiding this comment.
| list(APPEND SUBPACKAGES "inteldfp" "pcre2" "s_baltst" "bsl" "bbryu" "bdl" "bbl" "bal") | |
| list(APPEND SUBPACKAGES "inteldfp" "s_baltst" "bsl" "bbryu" "bdl" "bbl" "bal") |
|
The changes suggested so far should remove pcre2 vendoring. We should be able to make bbryu installation files not conflict with vcpkg's ryu. |
|
I have opened a PR to @jiayuehua's branch with all the fixes to remove the vendored pcre2. This version of bde installs ryu headers under a bbryu prefix in the installation path (ryu in vcpkg installs headers under a similar ryu prefix.) @BillyONeal is that sufficient to update this port? Thanks. |
|
@hallfox should also add a patch that remove vendoring intel decimal floating point library and use vcpkg'port intelrdfpmathlib instead. you can create a new pr branch base on this pr so that you can see ci error report immediately. |
|
ci report error : |
Locally, you can test with: which will ensure conflicting files aren't being installed. To submit something that works to us, also edit ci.baseline.txt and ci.feature.baseline.txt and remove the bde =skips and fix what the build lab comes back with. |
The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.