[vcpkg_find_acquire_program(NINJA)] Do not check version of system ninja on FreeBSD#46345
Merged
vicroms merged 1 commit intomicrosoft:masterfrom Jul 13, 2025
Conversation
VCPKG upgraded it's ninja version to 1.12.1 in microsoft/vcpkg@f576077 / microsoft#41980 . FreeBSD had ninja-1.12.1 in it's third party package repository, but reverted it to 1.11.0 (freebsd/freebsd-ports@1e1a1e9), as issues with ccache were discovered when using ninja-1.12.1. vcpkg does not deploy ninja on FreeBSD, and does not accept the version found on the system, either. Remove the version check on FreeBSD's branch, to allow vcpkg to use the pkg/ports version even if it is "outdated".
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vicroms
approved these changes
Jul 13, 2025
talregev
pushed a commit
to talregev/vcpkg
that referenced
this pull request
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VCPKG upgraded it's ninja version to 1.12.1 in f576077 / #41980 . FreeBSD had ninja-1.12.1 in it's third party package repository, but reverted it to 1.11.0 (freebsd/freebsd-ports@1e1a1e9), as issues with ccache were discovered when using ninja-1.12.1.
vcpkg does not deploy ninja on FreeBSD, and does not accept the version found on the system, either.
This PR removes the version check on FreeBSD's branch, allowing vcpkg to use the pkg/ports version, even if it is "outdated".
Fixes #46344 .