Skip to content

[g2o] Fix cholmod and csparse missing export symbols#45000

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
matlabbe:master
Jun 25, 2025
Merged

[g2o] Fix cholmod and csparse missing export symbols#45000
BillyONeal merged 3 commits intomicrosoft:masterfrom
matlabbe:master

Conversation

@matlabbe
Copy link
Copy Markdown
Contributor

@matlabbe matlabbe commented Apr 12, 2025 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Details: This fixes a linker issue when using g2o as library into downstream projects. The patches were taken from upstream repo:

@Mengna-Li Mengna-Li added the category:port-bug The issue is with a library, which is something the port should already support label Apr 14, 2025
@matlabbe matlabbe marked this pull request as ready for review April 27, 2025 23:17
@matlabbe
Copy link
Copy Markdown
Contributor Author

matlabbe commented May 11, 2025

It seems there was a CI error:

##[error]Unhandled exception. System.IO.IOException: No space left on device : '/Users/vcpkg/myagent/_diag/Worker_20250412-201837-utc.log'
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
   at
,##[error]We stopped hearing from agent VCPKGMM-02. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610
Started: Apr 12 at 2:16 PM
Duration: <1s

Can someone re-trigger that job? https://dev.azure.com/vcpkg/public/_build/results?buildId=114582&view=logs&j=7b75bd19-17d3-53d4-00fd-23f1a49a8ba4

@matlabbe matlabbe mentioned this pull request May 11, 2025
Closed
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jun 6, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Jun 24, 2025

C:\Dev\vcpkg\buildtrees\g2o\src\570f28570c-52341e24da.clean\g2o\stuff\opengl_primitives.h(55): error C2065: 'GLfloat': undeclared identifier

Probably should be a "supports".

Also should download the real patches for the additions. I'll push changes.

@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 24, 2025
@BillyONeal BillyONeal enabled auto-merge (squash) June 25, 2025 18:28
@matlabbe
Copy link
Copy Markdown
Contributor Author

matlabbe commented Jun 25, 2025

@BillyONeal I was not aware of this approach to include an upstream patch, it looks good! thanks

@BillyONeal BillyONeal merged commit 07dd18f into microsoft:master Jun 25, 2025
18 checks passed
talregev pushed a commit to talregev/vcpkg that referenced this pull request Aug 11, 2025
@matlabbe @BillyONeal @talregev
[g2o] Fix cholmod and csparse missing export symbols (microsoft#45000)
a19e866 
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@vicroms vicroms vicroms approved these changes

Assignees

@Mengna-Li Mengna-Li

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matlabbe @vicroms @BillyONeal @Mengna-Li