Skip to content

[dcmtk] code clean up#38223

Closed
jimwang118 wants to merge 14 commits intomicrosoft:masterfrom
jimwang118:clean-dcmtk
Closed

[dcmtk] code clean up#38223
jimwang118 wants to merge 14 commits intomicrosoft:masterfrom
jimwang118:clean-dcmtk

Conversation

@jimwang118
Copy link
Copy Markdown
Contributor

Modified based on comments.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-windows
x64-windows-static

@kevle kevle mentioned this pull request Apr 17, 2024
8 tasks
@jimwang118 jimwang118 marked this pull request as ready for review April 23, 2024 02:29
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 24, 2024
@JavierMatosD
Copy link
Copy Markdown
Contributor

I'm most likely going to take the changes in this #38249 since it includes this fix along with another port. Closing this for now. Thank you!

@jimwang118 jimwang118 deleted the clean-dcmtk branch April 25, 2024 01:57
data-queue pushed a commit that referenced this pull request Apr 30, 2024
#36124 (comment),  
#24633 (comment).
Related (fix): #38223 (merged
here.)

---------

Co-authored-by: Jim-Wang <wangzhijie05@beyondsoft.com>
yurybura pushed a commit to yurybura/vcpkg that referenced this pull request May 8, 2024
microsoft#36124 (comment),  
microsoft#24633 (comment).
Related (fix): microsoft#38223 (merged
here.)

---------

Co-authored-by: Jim-Wang <wangzhijie05@beyondsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants