Skip to content

[bde] Remove from the curated registry.#32601

Closed
BillyONeal wants to merge 1 commit intomicrosoft:masterfrom
BillyONeal:deindex-bde
Closed

[bde] Remove from the curated registry.#32601
BillyONeal wants to merge 1 commit intomicrosoft:masterfrom
BillyONeal:deindex-bde

Conversation

@BillyONeal
Copy link
Copy Markdown
Member

bde has been broken in vcpkg for a long time, as when we updated to a distro where python meant python3, it failed. #31961 , merged a couple of weeks ago, fixed this problem by updating to a more recent copy of bde. Unfortunately, the new copy of bde is link-incompatible with other vcpkg ports, as they vendor ryu and pcre2 with changes.

Given that this was broken for most customers for a long time anyway, I think we should deindex for now and bring it back if/when we have an understanding with upstream as to how this is to integrate with the rest of vcpkg' ecosystem.

bde has been broken in vcpkg for a long time, as when we updated to a distro where python meant python3, it failed. microsoft#31961 , merged a couple of weeks ago, fixed this problem by updating to a more recent copy of bde. Unfortunately, the new copy of bde is link-incompatible with other vcpkg ports, as they vendor ryu and pcre2 with changes.

Given that this was broken for most customers for a long time anyway, I think we should deindex for now and bring it back if/when we have an understanding with upstream as to how this is to integrate with the rest of vcpkg' ecosystem.
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jul 17, 2023
@jimwang118 jimwang118 self-assigned this Jul 18, 2023
@jimwang118 jimwang118 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 18, 2023
@BillyONeal
Copy link
Copy Markdown
Member Author

@adamncasey you did a lot of work to update this version. Do you have ideas on what we could do instead? For example, if bde hides all these symbols and doesn't try to install patched headers that could work for dynamic releases...

@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jul 18, 2023
@jimwang118 jimwang118 marked this pull request as draft July 19, 2023 02:07
@adamncasey
Copy link
Copy Markdown
Contributor

Thanks for raising - this is being looked into. There is a workable way forward here for ryu/pcre2 but suspect we won't be able to address this in the next few days.

@BillyONeal
Copy link
Copy Markdown
Member Author

Thanks for raising - this is being looked into. There is a workable way forward here for ryu/pcre2 but suspect we won't be able to address this in the next few days.

It doesn't need to be "next few days" as long as it is being worked on. We can "skip" it in our CI testing temporarily if you're actually working on it like we just did for openvino. How about we skip for, say, 30 days, and check back afterwards?

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Jul 19, 2023
Replaces microsoft#32601 ; will proceed with deindex only after some time for bde maintainers to fix this.
@BillyONeal BillyONeal closed this Jul 19, 2023
BillyONeal added a commit that referenced this pull request Jul 19, 2023
Replaces #32601 ; will proceed with deindex only after some time for bde maintainers to fix this.
@BillyONeal BillyONeal deleted the deindex-bde branch July 28, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants