Skip to content

[boost] Remove port version constraints#31572

Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom
JavierMatosD:remove_port_version_constraints
Jun 6, 2023
Merged

[boost] Remove port version constraints#31572
dan-shaw merged 5 commits intomicrosoft:masterfrom
JavierMatosD:remove_port_version_constraints

Conversation

@JavierMatosD
Copy link
Copy Markdown
Contributor

@JavierMatosD JavierMatosD commented May 22, 2023

This PR removes port version constraints from boost ports.

I can add the port version constraints for specific ports if there is a well-understood specific requirement for that port.

Tagging @Neumann-A since you tend to work on the boost ports.

Feedback is welcome :)

This is needed for #30836 to land.

@JavierMatosD JavierMatosD requested a review from BillyONeal May 23, 2023 00:28
@JonLiu1993 JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels May 23, 2023
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 23, 2023
@Neumann-A
Copy link
Copy Markdown
Contributor

Tagging @Neumann-A since you tend to work on the boost ports.

Not really. I basically never updated them as far as I remember. I just fixed the synchro and renaming stuff. The port version constrain probably automatically kicks in by the baseline? Is there a reason to not or to have them? You definetly will need them for the synchro update.

@Osyotr
Copy link
Copy Markdown
Contributor

Osyotr commented May 24, 2023

I guess the problem is that a change in one port requires making changes in a lot of other ports.
In practice nobody bothered update other ports so this change is ok.
What about moving dependencies from boost metaport to features and adding port version constraints to them?

@dan-shaw dan-shaw merged commit 5d3798a into microsoft:master Jun 6, 2023
@JavierMatosD JavierMatosD deleted the remove_port_version_constraints branch October 31, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants