[boost] pulling has_synchro bits from https://github.com/microsoft/vcpkg/pull…#30836
Conversation
# Conflicts: # ports/boost-atomic/vcpkg.json # ports/boost-modular-build-helper/boost-modular-build.cmake # ports/boost-modular-build-helper/vcpkg.json # versions/b-/boost-atomic.json # versions/b-/boost-modular-build-helper.json # versions/baseline.json
|
@BillyONeal, Could you please take a review? |
BillyONeal
left a comment
There was a problem hiding this comment.
The changes in here look good. However, clearly scripts/boost/generate-ports.ps1 has not been run, which will erase a bunch of these changes. I believe you and @ras0219-msft were going to propose changes to generate-ports.ps1, but in that case I think you're on the hook to have those changes in hand before we proceed. (That is, in an otherwise unchanged repo generate-ports.ps1 needs to result in no changes)
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
|
Depends on #31572. |
# Conflicts: # ports/boost-atomic/vcpkg.json # versions/b-/boost-atomic.json # versions/b-/boost-modular-build-helper.json
BillyONeal
left a comment
There was a problem hiding this comment.
This approval is assuming generate-ports.ps1 makes no changes.
@Neumann-A I want to pull out the
has_synchrobits from #27694