[boost-filesystem] fix emscripten build#29540
Merged
JavierMatosD merged 5 commits intomicrosoft:masterfrom Feb 9, 2023
Merged
Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for boost-build have changed but the version was not updated
version: 1.81.0#2
old SHA: 641f76f831109d1c1e6b412dc0be9f0c07f0c1fa
new SHA: 40cd5234db2baf10fb0a2b0ec8b40771910ca045
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.81.0#3
old SHA: 51714c0e72628b70c25c15e0a8d494672b955718
new SHA: d47cef023f39ac9d5f3a043d35cba1a74710e1b3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.81.0#3
old SHA: 51714c0e72628b70c25c15e0a8d494672b955718
new SHA: d47cef023f39ac9d5f3a043d35cba1a74710e1b3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Contributor
Author
|
@tobbi Hey, could you please test this? |
Contributor
Hey, I can confirm that the above changes fix the issue. Thanks for dealing with this so quickly! :) |
Cheney-W
approved these changes
Feb 9, 2023
Member
|
This forgot to run |
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 18, 2023
…rts.ps1. microsoft#29540 and microsoft#29481 forgot to rerun generate-ports.ps1. Note that the default port-version was bumped because most everything depends on boost-build that change touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29529
my previous pr #29481 fixed builds of some of non-header-only boost libs
however non-header-only libs that also depend on other non-header-only libs kept failing (like boost-filesystem). in this pr I finally managed to fix that properly. deleted cmake lines that were added in my previous pr as a hack
based on bfgroup/b2#111