Skip to content

[vcpkg-ci-boost] All triplets#28619

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
dg0yt:boost-icu-uwp
Dec 21, 2023
Merged

[vcpkg-ci-boost] All triplets#28619
BillyONeal merged 2 commits intomicrosoft:masterfrom
dg0yt:boost-icu-uwp

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Dec 29, 2022

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-boost/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-boost/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-boost/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-boost/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-boost/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • scripts/test_ports/vcpkg-ci-boost/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Dec 30, 2022
"homepage": "https://github.com/mapnik/mapnik",
"license": "LGPL-2.1-only",
"supports": "!(static & windows)",
"supports": "!(static & windows) & !uwp",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, mapnik is n/a in x64-uwp. But vcpkg ci still pulls in boost-regex[icu], resulting in boost-regex not being buildable in x64-uwp CI.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt dg0yt changed the title [boost-regex,vcpkg-ci-uwp] Fix uwp [vcpkg-ci-boost] All triplets Feb 26, 2023
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Feb 28, 2023

vcpkg-ci-boost:arm64-windows should build, not cascade, according to depend-info and dry-run install.
Still something pulling in an unsupported dependency?

@JonLiu1993
Copy link
Copy Markdown
Contributor

Pinging @dg0yt for response. Is work still being done for this PR?

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Mar 28, 2023

Yes, this is to be finished.

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Mar 28, 2023

The following ports request boost-mpi which transitively relies on msmpi:arm64-windows which is set to "skip" in vcpkg CI:
boost-graph-parallel
boost-property-map-parallel

If there is a chance for msmpi to work on arm64 (as indicated by "skip"), the the only solution is to hide the boost-mpi dependency behinde a feature, as done in other boost ports.

@dg0yt dg0yt marked this pull request as ready for review December 17, 2023 19:35
@JonLiu1993 JonLiu1993 added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels Dec 21, 2023
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 21, 2023
@BillyONeal
Copy link
Copy Markdown
Member

Not every day we get to merge things from almost a year ago, thanks!

@BillyONeal BillyONeal merged commit 38bd590 into microsoft:master Dec 21, 2023
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Dec 21, 2023

There are still some quite useful PRs waiting to be finished (or accepted)...

@dg0yt dg0yt deleted the boost-icu-uwp branch December 21, 2023 05:10
autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Dec 25, 2023
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants