[openexr] Side-by-side installation of version 2 and 3#26788
Closed
dg0yt wants to merge 26 commits intomicrosoft:masterfrom
Closed
[openexr] Side-by-side installation of version 2 and 3#26788dg0yt wants to merge 26 commits intomicrosoft:masterfrom
dg0yt wants to merge 26 commits intomicrosoft:masterfrom
Conversation
This is a preparation for updating port openexr to version 3.
dg0yt
commented
Sep 15, 2022
ports/openexr/vcpkg.json
Outdated
Contributor
Author
There was a problem hiding this comment.
openexr2 will be removed here once CI identified the ports which need to explicitly stay with openexr2.
Contributor
Author
|
Ports which still "need" openexr2
Ports which can use openexr3:
If everything can be moved to openexr3, port openexr should just be updated in-place. |
Contributor
Author
|
Everything OpenEXR 3 now. |
Contributor
Author
|
Obsolete, direct port update in #26862. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
This PR transforms port
openexrinto a portopenexr2which can coexist with a new portopenexr3. This approach is meant to mitigate theopenexrupdate issues which turned up in previous attempts to updateopenexr. The availability of OpenEXR 3 is urgent to unlock further updates to consuming ports and to restore broken features such asopenimageio[opencolorio](cf. [openimageio] Build error #26089).Notes:
include/openexr2/include/openexr3.openexr2's main pc file is renamed toOpenEXR2.pc.OpenEXR. However, there shouldn't be a wrapper for OpenEXR CONFIG. That's why the wrapper is maintained in legacy portopenexr2.openexr3is installed.)openimageio[opencolorio].Previous work: [openexr3] Add new port #25238 (only adding openexr3), [openexr] Update to 3.1.5 #24249, [openexr] Update to 3.1.4 #20957 (direct updates of openexr).
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no
Does your PR follow the maintainer guide?
WIP
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?I am still working on this PR.