[openexr] Update to 3.1.5 by Thomas1664 · Pull Request #24249 · microsoft/vcpkg

Thomas1664 · 2022-04-19T14:10:39Z

Describe the pull request

What does your PR fix?

Fixes #...
Note: Duplicate of [openexr] Update to 3.1.4 #20957
Which triplets are supported/not supported? Have you updated the CI baseline?

<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?

Your answer
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

<Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for osg but no changes to version or port version.
-- Version: 3.6.5#12
-- Old SHA: f438ec006b58ffd222b0f3bdce8d05b21611204e
-- New SHA: d1ca6a4010851c13c831ee1b215d3f93de453017
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for openexr but no changes to version or port version.
-- Version: 3.1.5
-- Old SHA: 428dc4ee11bf76291aef9d77936dc64be5d987ce
-- New SHA: 9073168a97cccf0f6794a572699c60d319372288
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for osg but no changes to version or port version.
-- Version: 3.6.5#12
-- Old SHA: f438ec006b58ffd222b0f3bdce8d05b21611204e
-- New SHA: d1ca6a4010851c13c831ee1b215d3f93de453017
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for osg but no changes to version or port version.
-- Version: 3.6.5#12
-- Old SHA: f438ec006b58ffd222b0f3bdce8d05b21611204e
-- New SHA: d1ca6a4010851c13c831ee1b215d3f93de453017
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for osg but no changes to version or port version.
-- Version: 3.6.5#12
-- Old SHA: f438ec006b58ffd222b0f3bdce8d05b21611204e
-- New SHA: d4a1112641f525f5f5f410ce1e2959e592b771b7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for osg but no changes to version or port version.
-- Version: 3.6.5#12
-- Old SHA: f438ec006b58ffd222b0f3bdce8d05b21611204e
-- New SHA: d4a1112641f525f5f5f410ce1e2959e592b771b7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/osg/portfile.cmake

dg0yt · 2022-04-20T06:43:29Z

I don't see an official FindOpenEXR.cmake in CMake. So what is the wrapper targeting at? Each downstream may have it is own variant of the find module. Differences must be handled in downstream ports. Port openexr must not accumulate dependencies on downstream find module implementations.

dg0yt · 2022-04-20T07:16:29Z

To limit downstream patching, would be a transitional option to:

add forwarding headers from openexr to imath (in particular for half.h)
add a dependency on imath config to openexr config?

dg0yt · 2022-04-20T07:20:18Z

To limit downstream patching, would be a transitional option to:

add forwarding headers from openexr to imath (in particular for half.h)

add a dependency on imath config to openexr config?

... perhaps implemented behind an opt-in openexr[imath-transition] feature.

Thomas1664 · 2022-04-20T08:20:20Z

@dg0yt Seems like you're more familiar with this than me. Feel free to open your own PR to update openexr. Honestly, I don't want to work on another OpenSSL-like patch thing.

Adela0814 · 2022-06-24T06:07:42Z

@Thomas1664 Is work still being done for this PR?

Thomas1664 · 2022-06-24T06:16:12Z

@Thomas1664 Is work still being done for this PR?

No. I don't have time for this.

Adela0814 · 2022-06-24T07:01:38Z

Closing this PR, please reopen if you continue this work.

chausner added 30 commits October 24, 2021 00:50

Update openexr to 3.1.2

02c2316

Update CI baseline

32d3d13

Try to fix git FetchContent issue on Windows

7acc150

Update git-tree hash

37df542

Workaround Imath find_dependency issue

ae0acae

Update git-tree hash

90b8edd

Use separate imath dependency

2b7d178

Merge branch 'master' into openexr-3.1.2

454a9c8

Make freeimage compatible with openexr and imath

4ae84bf

Update CI baseline

0814c91

Merge branch 'freeimage-openexr-3.1.2' into openexr-3.1.2

16f9452

Remove unused patch

b187747

Fix openexr dependency in osg

6e2f3cc

Update CI baseline

b145213

Increment port-version of osg

04f39a0

Update CI baseline

3309a8e

Modernize osg

67af2d7

Update CI baseline

2fa8d07

Fix osg build

2c37a7e

Update CI baseline

bfbeba5

Update to 3.1.3

be907e5

Update git-tree hash

4161569

Merge branch 'master' into openexr-3.1.2

221948d

Update git-tree hash

e0e1dd7

Merge remote-tracking branch 'upstream/master' into openexr-3.1.2

1a65106

Bump port-version of freeimage

fd133ad

Update CI baseline

fd8991b

Bump port-version of osg

0894cc8

Update CI baseline

df8988e

Add license metadata to freeimage, openexr and osg

7919c2d

chausner and others added 4 commits April 10, 2022 13:04

Fix devil on macOS

f84687b

Update CI baseline

347a52e

[openexr] Update to 3.1.5

28c395c

version

3badaa3

github-actions bot approved these changes Apr 19, 2022

View reviewed changes

Merge branch 'openexr-3.1.2' into openexr

dd05562