Skip to content

[vcpkg baseline][many ports] Fix baseline issues#26646

Merged
dan-shaw merged 25 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-baseline-20220901
Sep 14, 2022
Merged

[vcpkg baseline][many ports] Fix baseline issues#26646
dan-shaw merged 25 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-baseline-20220901

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Sep 2, 2022 •
edited
Loading

  1. PASSING, REMOVE FROM FAIL LIST: openexr:arm64-windows

Related: https://dev.azure.com/vcpkg/public/_build/results?buildId=77258&view=results

  1. libpq:arm64-windows:
    libpq uses 2 windows api GetUserName and SHGetFolderPath but not add the related system libs Advapi32.lib and Shell32.lib in build process, fix this. (Not happened no CI but on my locally machine)

Moved to #26735

  1. osg:arm64-windows:
   _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED_EXITCODE (advanced)
   _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED_EXITCODE__TRYRUN_OUTPUT (advanced)
For details see D:/buildtrees/osg/arm64-windows-rel/TryRunResults.cmake

upstream PR: openscenegraph/OpenSceneGraph#1164
Related: https://dev.azure.com/vcpkg/public/_build/results?buildId=77258&view=results

Moved to #26698

  1. PASSING, REMOVE FROM FAIL LIST: qwtw:x64-windows:

upstream issue: ig-or/qwtw#2
Related: https://dev.azure.com/vcpkg/public/_build/results?buildId=77258&view=results

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Sep 2, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/kf5globalaccel/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
View reviewed changes
@JackBoosY JackBoosY requested a review from LilyWangLL September 2, 2022 01:52
LilyWangLL
LilyWangLL previously approved these changes Sep 2, 2022
View reviewed changes
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 2, 2022
@JackBoosY JackBoosY changed the title [vcpkg baseline][kf5globalaccel] Re-fix build on Windows [vcpkg baseline][kf5globalaccel/openexr] Re-fix build on Windows and cleanup baseline Sep 2, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
View reviewed changes
@JackBoosY JackBoosY changed the title [vcpkg baseline][kf5globalaccel/openexr] Re-fix build on Windows and cleanup baseline [vcpkg baseline][kf5globalaccel/openexr] Fix baseline issues Sep 2, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/osg/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY changed the title [vcpkg baseline][kf5globalaccel/openexr] Fix baseline issues [vcpkg baseline][many ports] Fix baseline issues Sep 2, 2022
@JackBoosY JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 2, 2022
Neumann-A
Neumann-A reviewed Sep 2, 2022
View reviewed changes
Neumann-A
Neumann-A reviewed Sep 2, 2022
View reviewed changes
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 8, 2022
dg0yt
dg0yt suggested changes Sep 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osg needs more fixes, at least wrt OpenEXR, #26698.

@dan-shaw dan-shaw added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Sep 8, 2022
@LilyWangLL LilyWangLL mentioned this pull request Sep 9, 2022
Merged
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 9, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 9, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Sep 9, 2022
View reviewed changes
JackBoosY added 2 commits September 9, 2022 02:29
github-actions[bot]
github-actions bot previously approved these changes Sep 9, 2022
View reviewed changes
dg0yt
dg0yt suggested changes Sep 9, 2022
View reviewed changes
@JonLiu1993 JonLiu1993 mentioned this pull request Sep 13, 2022
Merged
@JackBoosY JackBoosY mentioned this pull request Sep 14, 2022
Merged
@dan-shaw dan-shaw merged commit d4dd1d3 into microsoft:master Sep 14, 2022
@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20220901 branch September 15, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JavierMatosD JavierMatosD Awaiting requested review from JavierMatosD

+3 more reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@dg0yt dg0yt dg0yt requested changes

@LilyWangLL LilyWangLL LilyWangLL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@LilyWangLL LilyWangLL

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JackBoosY @dg0yt @Neumann-A @LilyWangLL @dan-shaw