Skip to content

[libpq] Fix arm64-windows build with Visual Studio 2017#26735

Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-libpq-arm-build-vs2017
Closed

[libpq] Fix arm64-windows build with Visual Studio 2017#26735
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-libpq-arm-build-vs2017

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

libpq uses 2 windows api GetUserName and SHGetFolderPath but not add the related system libs Advapi32.lib and Shell32.lib in build process.
Fix this.

cc @Neumann-A

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Sep 9, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 1ddafcb6f62ee3488b6e32621d6aa343038a8ccc -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 53b0bf5..8962686 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4010,7 +4010,7 @@
     },
     "libpq": {
       "baseline": "14.4",
-      "port-version": 0
+      "port-version": 1
     },
     "libpqxx": {
       "baseline": "7.7.3",
diff --git a/versions/l-/libpq.json b/versions/l-/libpq.json
index f01f4c4..5d82eb9 100644
--- a/versions/l-/libpq.json
+++ b/versions/l-/libpq.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "289842e1c5aa972bed6b6bf2af853d44a344002a",
+      "version": "14.4",
+      "port-version": 1
+    },
     {
       "git-tree": "2b3456bfb8b04525c44007f3c8a04b7e208d639d",
       "version": "14.4",

@JackBoosY JackBoosY closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants