[vcpkg baseline][kf5globalaccel] Fix build on windows when x11 is around#26564
[vcpkg baseline][kf5globalaccel] Fix build on windows when x11 is around#26564JavierMatosD merged 1 commit intomicrosoft:masterfrom
Conversation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5globalaccel/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5globalaccel/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/kf5globalaccel/vcpkg.json
Valid values for the license field can be found in the documentation
BillyONeal
left a comment
There was a problem hiding this comment.
@JavierMatosD indicated that the disable is controlling:
https://github.com/KDE/kglobalaccel/blob/master/CMakeLists.txt#L71
which is ... extremely cursed. But given that it has that behavior, this resolves the problem without needing patches, so LGTM
|
Thanks! |
[kf5globalaccel] Fix build on windows when x11 is around (microsoft#26564)
Describe the pull request
What does your PR fix?
Fixes a spurious build issue which depends on the presence of x11 on the target system (see [vcpkg script] Ios support for meson and autotools based ports #25670)