[gettext] fix ios compile, add ios support to vcpkg_configure_make#26520
[gettext] fix ios compile, add ios support to vcpkg_configure_make#26520russelltg wants to merge 9 commits intomicrosoft:masterfrom
Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for gettext have changed but the version was not updated
version: 0.21#9
old SHA: 5bf45743516e2ae999eb14017370828e237ad533
new SHA: fd6cc135f2f5e172cb8c82ef8bcd51c57a3539aa
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gettext/vcpkg.json
Valid values for the license field can be found in the documentation
|
So it seems like the libraries are LGPL and binaries are GPL: https://www.gnu.org/software/gettext/manual/html_node/Licenses.html How should that be reflected in the |
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gettext/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gettext/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gettext/vcpkg.json
Valid values for the license field can be found in the documentation
Conditions can't be expressed, so you have to use |
|
See also #25670 |
|
@russelltg in order to mutualize the efforts as much as possible and avoid duplicate work and merge conflicts, could you check if #25670 also solves your If there is something that still needs to be done for If there is good reasons to stick to this work instead, I can also dismiss mine. |
|
Your PR's do everything needed for gettext, I'm pretty sure. I'll close this one for now and will reopen a new PR with the gettext change when #25670 lands. |
|
Thanks, happy to see more people helping on the iOS bits! |
I do have a few questions:
z_vcpkg_determine_autotools_target_arch_iosmake any sense? I honestly felt confused thatz_vcpkg_determine_autotools_target_arch_macdefaults toVCPKG_DETECTED_CMAKE_HOST_SYSTEM_PROCESSORinstead ofVCPKG_TARGET_ARCHITECTURE. arm64 is an acceptable target architecture on iOS, it seems, no need to translate to aarch64ports/vcpkg-cmake-get-vars/cmake_get_vars/CMakeLists.txt?What does your PR fix?
Fixes gettext port on iOS, and maybe some others too. Supersedes [configure_make] fix regression: don't set C*_FOR_BUILD environment variables for ios #26519
Which triplets are supported/not supported? Have you updated the CI baseline?
arm64-ios, arm-ios
Does your PR follow the maintainer guide?
Yes