[configure_make] fix regression: don't set C*_FOR_BUILD environment variables for ios#26519
Closed
russelltg wants to merge 1 commit intomicrosoft:masterfrom
Closed
[configure_make] fix regression: don't set C*_FOR_BUILD environment variables for ios#26519russelltg wants to merge 1 commit intomicrosoft:masterfrom
russelltg wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
Sorry not a regression! That is intentional. If there is a crossbuild issue with gettext it needs to be solved in the context of host dependencies in vcpkg. |
Contributor
Author
|
I see, I'll look into it. |
Contributor
|
Note that the CI is still building this PR and the other two PRs. Each rebuilding almost the entire world. Which makes other PRs wait. (There is little CI control for contributors, but you might force-push no-changes to cancel the long-running build before closing the PR.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes building gettext for ios, which regressed in 624f1b4
Which triplets are supported/not supported? Have you updated the CI baseline?
arm64-ios, arm-ios
Does your PR follow the maintainer guide?
Yes