Skip to content

[vcpkg] add updated compile wrapper for clang-cl#26340

Merged
JavierMatosD merged 6 commits intomicrosoft:masterfrom
Neumann-A:clang-cl_compile_wrapper
Aug 30, 2022
Merged

[vcpkg] add updated compile wrapper for clang-cl#26340
JavierMatosD merged 6 commits intomicrosoft:masterfrom
Neumann-A:clang-cl_compile_wrapper

Conversation

@Neumann-A
Copy link
Copy Markdown
Contributor

@Neumann-A Neumann-A commented Aug 13, 2022

has already been merged upstream but I have no clue when it will be in automake from msys.
The relevant change is line 259.

Alternatively we could just patch the msys download? But where should those patches be stored?

github-actions[bot]
github-actions bot previously approved these changes Aug 13, 2022
View reviewed changes
@Cheney-W Cheney-W self-assigned this Aug 15, 2022
@Cheney-W Cheney-W changed the title add updated compile wrapper for clang-cl [vcpkg] add updated compile wrapper for clang-cl Aug 15, 2022
@Cheney-W Cheney-W added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Aug 15, 2022
@JavierMatosD
Copy link
Copy Markdown
Contributor

JavierMatosD commented Aug 15, 2022

has already been merged upstream but I have no clue when it will be in automake from msys. The relevant change is line 259.

Alternatively we could just patch the msys download? But where should those patches be stored?

I am concerned about the potential licensing implications of this. Is it unreasonable to wait for msys?

@JavierMatosD JavierMatosD added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Aug 15, 2022
@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Aug 15, 2022

I am concerned about the potential licensing implications of this. Is it unreasonable to wait for msys?

I feared that that would be the answer. So where should I store the patch for msys ? ;)

@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Aug 18, 2022

scripts/msys/xyz.patch; vcpkg_acquire_msys() then can apply the patch after un-tarring all the packages together but before renaming if it detects that the automake package was requested.

github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2022
View reviewed changes
Neumann-A
Neumann-A commented Aug 18, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2022
View reviewed changes
@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Aug 18, 2022

@ras0219-msft: Done.

This was referenced Aug 23, 2022
Closed
Closed
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 29, 2022
@JavierMatosD
Copy link
Copy Markdown
Contributor

JavierMatosD commented Aug 30, 2022

Thanks!

@JavierMatosD JavierMatosD merged commit f688b2e into microsoft:master Aug 30, 2022
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Aug 30, 2022
@Jimmy-Hu
Merge pull request #1128 from microsoft/master
070bdfb 
[vcpkg] add updated compile wrapper for clang-cl (microsoft#26340)
@Neumann-A Neumann-A deleted the clang-cl_compile_wrapper branch August 31, 2022 17:35
@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Aug 31, 2022

@dg0yt Couldn't you also patch libtool with this? Or am I pinging the wrong person.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Sep 4, 2022

@Neumann-A libtool is considered external and not accepted as a port.

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Sep 4, 2022

@Neumann-A libtool is considered external and not accepted as a port.

didn't you have changes to bash scripts which could now be patched into vcpkg_acquire_msys ?

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Sep 4, 2022

@Neumann-A Sorry, the PR title was unable to convey the information that this PR contains relevant changes, such as a PATCHES option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Neumann-A @JavierMatosD @ras0219-msft @dg0yt @Cheney-W @JackBoosY