[tensorflow-cc] Update to 2.10.0 by JackyYin · Pull Request #24861 · microsoft/vcpkg

JackyYin · 2022-05-22T13:40:08Z

Update tensorflow-cc to 2.10.0.

Bacause tensorflow-cc depends on tensorflow-common and tensorflow depends on tensorflow-common too, so I update all of these package to 2.10.0 at once.

Also added a new host port vcpkg-tool-bazel as a dependency of tensorflow and tensorflow-cc, bacause tensorflow 2.10.0 requires newer version of bazel.

Tested triplet:
x64-osx
x64-linux
arm64-osx

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/tensorflow-cc/vcpkg.json
ports/tensorflow-common/vcpkg.json
ports/tensorflow/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/tensorflow-cc/vcpkg.json
ports/tensorflow-common/vcpkg.json
ports/tensorflow/vcpkg.json

Valid values for the license field can be found in the documentation

ras0219-msft · 2022-05-23T20:44:20Z

Thanks for the PR!

Can we be more surgical about these removals? What are they specifically removing? We should be redirecting all bazel files to stay within the vcpkg instance.

JackyYin · 2022-05-24T02:20:16Z

Hello @ras0219-msft,

Can we be more surgical about these removals? What are they specifically removing? We should be redirecting all bazel files to stay within the vcpkg instance.

This is where my pipeline failed : https://dev.azure.com/vcpkg/public/_build/results?buildId=72552&view=logs&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad.

Firstly, the Create /home/agent and Create /mnt/vcpkg-ci and /mnt/vcpkg-ci/downloads steps both have the same error message:

cannot create directory ‘xxxx’: File exists

Then in the Test Modified Ports for x64-linux step, we can see following error:

Starting vcpkg CI clean
Clearing contents of /mnt/vcpkg-ci/buildtrees
Failure to remove_all_inside("/mnt/vcpkg-ci/buildtrees") due to file "/mnt/vcpkg-ci/buildtrees/tensorflow/.bzl/02c0d9509a4399b7d0b466397e539271/sandbox/inaccessibleHelperDir": Permission denied
Exception: /agent/_work/1/s/scripts/azure-pipelines/test-modified-ports.ps1:132
Line |
 132 |      throw "vcpkg clean failed"
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~
     | vcpkg clean failed

##[error]PowerShell exited with code '1'.
##[error]PowerShell wrote one or more lines to the standard error stream.
##[error]Exception: /agent/_work/1/s/scripts/azure-pipelines/test-modified-ports.ps1:132
Line |
 132 |      throw "vcpkg clean failed"
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~
     | vcpkg clean failed

Seems like it's an error raised from vcpkg x-ci-clean command, which failed to remove /mnt/vcpkg-ci/buildtrees directory.

IMHO, it's a better idea to cleanup those working directory, so we can get a fresh work space everytime when we trigger the workflow.

JackyYin · 2022-05-26T11:23:56Z

Hello @ras0219-msft ,
Any update or comment here?

JonLiu1993 · 2022-06-13T07:42:20Z

@ras0219-msft ,Could you please take a review?

abique · 2022-06-13T09:54:46Z

2.9.0 is out now.

JonLiu1993 · 2022-06-14T06:56:05Z

@JackyYin ,Could you please update tensorflow-cc to the lateste version 2.9.0?

abique · 2022-06-14T08:19:52Z

By the way, is it correct that tensor-flow is not supported on arm?
Because here brew can provide libtensorflow to arm m1.

JackyYin · 2022-06-14T08:43:45Z

@JackyYin ,Could you please update tensorflow-cc to the lateste version 2.9.0?

It's my pleasure, I will update this patch as soon as possible.

japm48 · 2022-09-11T11:20:54Z

@JackyYin TensorFlow 2.10 has been released, could you try updating this PR?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for tensorflow-common have changed but the version was not updated
version: 2.10.0
old SHA: 44ba099d1b61759bd520a48486e2b88fef616397
new SHA: 86fd281d0d4da2f16538f684741e3fa07cc98406
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

JackyYin · 2022-09-21T05:03:32Z

@JackyYin TensorFlow 2.10 has been released, could you try updating this PR?

Hi @japm48,
updated Tensorflow to 2.10, please try it and let me know if there're any other problems.

JackyYin · 2022-09-21T05:05:39Z

Hi @JonLiu1993 ,
The CI checks failed because of command vcpkg x-ci-clean, could you help to re-trigger the check?

https://dev.azure.com/vcpkg/public/_build/results?buildId=78366&view=logs&jobId=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&t=da63cf11-1f12-503b-6d64-3b2fb713c172

JonLiu1993 · 2022-09-21T06:11:20Z

/azp run

azure-pipelines · 2022-09-21T06:11:32Z

Azure Pipelines successfully started running 1 pipeline(s).

…orflow-cc-2.8.0

vicroms

LGTM

ALittleDruid · 2022-10-22T08:40:00Z

build failure on Windows x64

-- Configuring TensorFlow (dbg)
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
Command failed: D:/vcpkg/downloads/tools/msys2/70289b324bc026d6/mingw64/bin/python3.exe D:/build/tensorflow/x64-windows-dbg/configure.py --workspace D:/build/tensorflow/x64-windows-dbg
Working Directory: D:/build/tensorflow/x64-windows-dbg
Error code: 1
See logs for more information:
D:\build\tensorflow\config-x64-windows-dbg-out.log

Call Stack (most recent call first):
installed/x64-windows/share/tensorflow-common/tensorflow-common.cmake:187 (vcpkg_execute_required_process)
ports/tensorflow/portfile.cmake:5 (include)
scripts/ports.cmake:147 (include)

config-x64-windows-dbg-out.log

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 5aaf4d2 to eae9113 Compare May 22, 2022 13:40

github-actions bot approved these changes May 22, 2022

View reviewed changes

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from eae9113 to 83a8121 Compare May 22, 2022 13:48

github-actions bot approved these changes May 22, 2022

View reviewed changes

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 83a8121 to 49f294a Compare May 22, 2022 14:03

github-actions bot approved these changes May 22, 2022

View reviewed changes

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 49f294a to 7ab0dc4 Compare May 22, 2022 14:12

github-actions bot approved these changes May 22, 2022

View reviewed changes

JonLiu1993 self-assigned this May 23, 2022

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 23, 2022

JonLiu1993 previously approved these changes May 23, 2022

View reviewed changes

JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 23, 2022

ras0219-msft added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels May 23, 2022

JonLiu1993 removed the requires:author-response label Jun 13, 2022

LilyWangLL assigned ras0219-msft Jun 14, 2022

JonLiu1993 added the requires:author-response label Jun 14, 2022

JackyYin added a commit to JackyYin/vcpkg that referenced this pull request Jun 14, 2022

chore: upgrade tensorflow-cc portfile (microsoft#24861)

e11d674

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 7ab0dc4 to e11d674 Compare June 14, 2022 09:06

JackBoosY requested a review from BillyONeal August 30, 2022 12:17

LilyWangLL mentioned this pull request Sep 2, 2022

[tensorflow] Build error #26609

Closed

JackyYin dismissed stale reviews from JackBoosY and github-actions[bot] via 41ff788 September 21, 2022 04:47

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 8555098 to 41ff788 Compare September 21, 2022 04:47

github-actions bot requested changes Sep 21, 2022

View reviewed changes

JackyYin changed the title ~~[tensorflow-cc] Update to 2.9.1~~ [tensorflow-cc] Update to 2.10.0 Sep 21, 2022

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 41ff788 to e168873 Compare September 21, 2022 04:49

github-actions bot previously approved these changes Sep 21, 2022

View reviewed changes

chore: upgrade tensorflow-cc portfile (microsoft#24861)

81c45c2

JackyYin dismissed github-actions[bot]’s stale review via 81c45c2 September 22, 2022 05:53

JackyYin force-pushed the tensorflow-cc-2.8.0 branch from e168873 to 81c45c2 Compare September 22, 2022 05:53

github-actions bot approved these changes Sep 22, 2022

View reviewed changes

vicroms added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Oct 13, 2022

Merge branch 'master' of https://github.com/Microsoft/vcpkg into tens…

dd182ac

…orflow-cc-2.8.0

github-actions bot approved these changes Oct 14, 2022

View reviewed changes

vicroms approved these changes Oct 15, 2022

View reviewed changes

LilyWangLL mentioned this pull request Oct 17, 2022

[tensorflow] build failure versions [2.7.0#2][2.7.0#1][2.7.0][2.6.0] #27252

Closed

autoantwort mentioned this pull request Oct 23, 2022

[tensorflow:arm64-osx] build failure #27411

Closed

BillyONeal mentioned this pull request Nov 1, 2022

Add vcpkg_minimum_required before using VERSION. #27598

Merged

JonLiu1993 mentioned this pull request Apr 23, 2023

[tensorflow-cc] build failure #7995

Closed

Conversation

JackyYin commented May 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

ras0219-msft commented May 23, 2022

Uh oh!

JackyYin commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackyYin commented May 26, 2022

Uh oh!

JonLiu1993 commented Jun 13, 2022

Uh oh!

abique commented Jun 13, 2022

Uh oh!

JonLiu1993 commented Jun 14, 2022

Uh oh!

abique commented Jun 14, 2022

Uh oh!

JackyYin commented Jun 14, 2022

Uh oh!

japm48 commented Sep 11, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JackyYin commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackyYin commented Sep 21, 2022

Uh oh!

JonLiu1993 commented Sep 21, 2022

Uh oh!

azure-pipelines bot commented Sep 21, 2022

Uh oh!

vicroms left a comment

Choose a reason for hiding this comment

Uh oh!

ALittleDruid commented Oct 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

JackyYin commented May 22, 2022 •

edited

Loading

JackyYin commented May 24, 2022 •

edited

Loading

JackyYin commented Sep 21, 2022 •

edited

Loading