Dont clober cmake program path by Neumann-A · Pull Request #23755 · microsoft/vcpkg

Neumann-A · 2022-03-24T22:58:05Z

No description provided.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qtdeclarative but no changes to version or port version.
-- Version: 6.2.4
-- Old SHA: ea64315431fd028d453a27e999d7e696f48923d4
-- New SHA: 0030775881ccb5ce1bc27b59e93e161f4e875fcb
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

dg0yt · 2022-03-25T05:17:20Z

How about avoiding GLOB_RECURSE, and explicitly pass the few expected patterns only? App.

file(GLOB Z_VCPKG_TOOLS_DIRS LIST_DIRECTORIES true "${tools_base_path}/*" "${tools_base_path}/*/bin")
file(GLOB Z_VCPKG_TOOLS_FILES LIST_DIRECTORIES false "${tools_base_path}/*" "${tools_base_path}/*/bin")

TBH I would prefer to limit the length of PATH by not add /tools/<Pkg> if there is /tools/<Pkg>/bin. This would need more changes.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qtdeclarative but no changes to version or port version.
-- Version: 6.2.4
-- Old SHA: ea64315431fd028d453a27e999d7e696f48923d4
-- New SHA: c3489b4d8d989da4bfeb9360bb915063454da0a1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

scripts/buildsystems/vcpkg.cmake

…_program_path

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qtdeclarative but no changes to version or port version.
-- Version: 6.2.4
-- Old SHA: ea64315431fd028d453a27e999d7e696f48923d4
-- New SHA: c3489b4d8d989da4bfeb9360bb915063454da0a1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qtdeclarative but no changes to version or port version.
-- Version: 6.2.4
-- Old SHA: ea64315431fd028d453a27e999d7e696f48923d4
-- New SHA: c3489b4d8d989da4bfeb9360bb915063454da0a1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ports/qtdeclarative/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qtdeclarative but no changes to version or port version.
-- Version: 6.2.4
-- Old SHA: ea64315431fd028d453a27e999d7e696f48923d4
-- New SHA: f6156793da924531262a5b0925c00ee14af7481e
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@Neumann-A

* [Most recent nightly build failed](https://dev.azure.com/vcpkg/public/_build/results?buildId=69427) * [Validation of this tool update failed](https://dev.azure.com/vcpkg/public/_build/results?buildId=69417) ## Common to both: PASSING, REMOVE FROM FAIL LIST: chartdir:x64-windows (.\scripts\ci.baseline.txt) PASSING, REMOVE FROM FAIL LIST: chartdir:x64-windows-static-md (.\scripts\ci.baseline.txt) PASSING, REMOVE FROM FAIL LIST: chartdir:x86-windows (.\scripts\ci.baseline.txt) Probably fixed by microsoft#23701 PASSING, REMOVE FROM FAIL LIST: gmp:x64-uwp (.\scripts\ci.baseline.txt) PASSING, REMOVE FROM FAIL LIST: gmp:x64-windows-static-md (.\scripts\ci.baseline.txt) Probably fixed by microsoft#23466 ? REGRESSION: colmap:x64-windows-static-md failed with BUILD_FAILED. If expected, add colmap:x64-windows-static-md=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. I don't know exactly what changed. I observe that * this thing depends on a *lot* of stuff * on March 14 we didn't even attempt to build this * the x64-windows ones are already in the baseline so I skipped it. REGRESSION: qtdeclarative:x64-windows. If expected, add qtdeclarative:x64-windows=fail to .\scripts\ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. This is a reporting change: The new world order also includes host build failures which is why it's duplicated. See also microsoft#23714 See also microsoft#23490 I'm nervous about baslining this because it seems most of the qt world is built on top of this port I filed microsoft#23824 about this and @Neumann-A indicated this should be fixed by microsoft#23755 REGRESSION: nettle:x64-uwp. If expected, add nettle:x64-uwp=fail to .\scripts\ci.baseline.txt. REGRESSION: nettle:x64-windows-static-md. If expected, add nettle:x64-windows-static-md=fail to .\scripts\ci.baseline.txt. REGRESSION: nettle:x64-uwp failed with BUILD_FAILED. If expected, add nettle:x64-uwp=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: nettle:x64-windows-static-md failed with POST_BUILD_CHECKS_FAILED. If expected, add nettle:x64-windows-static-md=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. Didn't analyze, probably fixed by microsoft#23519 ? REGRESSION: libgpg-error:x64-uwp. If expected, add libgpg-error:x64-uwp=fail to .\scripts\ci.baseline.txt. REGRESSION: libgpg-error:x64-uwp failed with BUILD_FAILED. If expected, add libgpg-error:x64-uwp=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. This was broken by VS2022 update: ``` C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Microsoft.AppXPackage.Targets(892,25): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformMinVersion)" that evaluates to "" instead of a number, in condition "'$(TargetPlatformMinVersion)' >= '10.0.17200.0'". [C:\Dev\vcpkg\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error_winrt.vcxproj] ``` REGRESSION: libmikmod:x64-osx. If expected, add libmikmod:x64-osx=fail to .\scripts\ci.baseline.txt. REGRESSION: libmikmod:x64-osx failed with BUILD_FAILED. If expected, add libmikmod:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt. Broken between [2022-03-16](https://dev.azure.com/vcpkg/public/_build/results?buildId=68947) and [2022-03-18](https://dev.azure.com/vcpkg/public/_build/results?buildId=69051). Unfortunately I don't see obvious reasons why. Nothing else depends on this and nobody has noticed in 2 weeks, so I'm baslining it for now. (Will investigate shortly...) ## Only broken in tool update: REGRESSION: mesa:x64-windows failed with BUILD_FAILED. If expected, add mesa:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. ``` -- Downloading https://gitlab.freedesktop.org/mesa/mesa/-/archive/mesa-21.2.5/mesa-mesa-21.2.5.tar.gz -> mesa-mesa-mesa-21.2.5-1.tar.gz... -- Extracting source /Users/vagrant/Data/downloads/mesa-mesa-mesa-21.2.5-1.tar.gz -- Applying patch swravx512-post-static-link.patch -- Applying patch swr-msvc-2.patch -- Applying patch swr-llvm13.patch -- Applying patch radv-msvc-llvm13-2.patch -- Applying patch d3d10sw.patch -- Using source at /Users/vagrant/Data/buildtrees/mesa/src/esa-21.2.5-2df234d2b1.clean Traceback (most recent call last): File "<string>", line 1, in <module> ModuleNotFoundError: No module named 'mako' CMake Error at ports/mesa/portfile.cmake:85 (message): Python package 'mako' needs to be installed for port 'mesa'. Complete list of required python packages: setuptools;mako Call Stack (most recent call first): ports/mesa/portfile.cmake:91 (vcpkg_get_python_package) scripts/ports.cmake:145 (include) ``` Looks like this is being tracked by microsoft#23089 ; perhaps that we don't have as aggressive a recycling strategy for macos boxes as we do for the others has let different machines give different results? ## Only broken without tool update: REGRESSION: chromium-base:x64-osx. If expected, add chromium-base:x64-osx=fail to .\scripts\ci.baseline.txt. This one has been constantly flaky; I baselined it. REGRESSION: libxml2:x64-osx. If expected, add libxml2:x64-osx=fail to .\scripts\ci.baseline.txt. This port uses vcpkg_from_git and the upstream server was down during the build.

@Neumann-A

* Update vcpkg-tool to 2022-03-24 * Hook up microsoft/vcpkg-tool#345 * Hook up microsoft/vcpkg-tool#442 * Update vcpkg-tool to 2022-03-25 * Analysis of failures. * [Most recent nightly build failed](https://dev.azure.com/vcpkg/public/_build/results?buildId=69427) * [Validation of this tool update failed](https://dev.azure.com/vcpkg/public/_build/results?buildId=69417) ## Common to both: PASSING, REMOVE FROM FAIL LIST: chartdir:x64-windows (.\scripts\ci.baseline.txt) PASSING, REMOVE FROM FAIL LIST: chartdir:x64-windows-static-md (.\scripts\ci.baseline.txt) PASSING, REMOVE FROM FAIL LIST: chartdir:x86-windows (.\scripts\ci.baseline.txt) Probably fixed by #23701 PASSING, REMOVE FROM FAIL LIST: gmp:x64-uwp (.\scripts\ci.baseline.txt) PASSING, REMOVE FROM FAIL LIST: gmp:x64-windows-static-md (.\scripts\ci.baseline.txt) Probably fixed by #23466 ? REGRESSION: colmap:x64-windows-static-md failed with BUILD_FAILED. If expected, add colmap:x64-windows-static-md=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. I don't know exactly what changed. I observe that * this thing depends on a *lot* of stuff * on March 14 we didn't even attempt to build this * the x64-windows ones are already in the baseline so I skipped it. REGRESSION: qtdeclarative:x64-windows. If expected, add qtdeclarative:x64-windows=fail to .\scripts\ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: qtdeclarative:x64-windows failed with BUILD_FAILED. If expected, add qtdeclarative:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. This is a reporting change: The new world order also includes host build failures which is why it's duplicated. See also #23714 See also #23490 I'm nervous about baslining this because it seems most of the qt world is built on top of this port I filed #23824 about this and @Neumann-A indicated this should be fixed by #23755 REGRESSION: nettle:x64-uwp. If expected, add nettle:x64-uwp=fail to .\scripts\ci.baseline.txt. REGRESSION: nettle:x64-windows-static-md. If expected, add nettle:x64-windows-static-md=fail to .\scripts\ci.baseline.txt. REGRESSION: nettle:x64-uwp failed with BUILD_FAILED. If expected, add nettle:x64-uwp=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. REGRESSION: nettle:x64-windows-static-md failed with POST_BUILD_CHECKS_FAILED. If expected, add nettle:x64-windows-static-md=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. Didn't analyze, probably fixed by #23519 ? REGRESSION: libgpg-error:x64-uwp. If expected, add libgpg-error:x64-uwp=fail to .\scripts\ci.baseline.txt. REGRESSION: libgpg-error:x64-uwp failed with BUILD_FAILED. If expected, add libgpg-error:x64-uwp=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. This was broken by VS2022 update: ``` C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Microsoft.AppXPackage.Targets(892,25): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformMinVersion)" that evaluates to "" instead of a number, in condition "'$(TargetPlatformMinVersion)' >= '10.0.17200.0'". [C:\Dev\vcpkg\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error_winrt.vcxproj] ``` REGRESSION: libmikmod:x64-osx. If expected, add libmikmod:x64-osx=fail to .\scripts\ci.baseline.txt. REGRESSION: libmikmod:x64-osx failed with BUILD_FAILED. If expected, add libmikmod:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt. Broken between [2022-03-16](https://dev.azure.com/vcpkg/public/_build/results?buildId=68947) and [2022-03-18](https://dev.azure.com/vcpkg/public/_build/results?buildId=69051). Unfortunately I don't see obvious reasons why. Nothing else depends on this and nobody has noticed in 2 weeks, so I'm baslining it for now. (Will investigate shortly...) ## Only broken in tool update: REGRESSION: mesa:x64-windows failed with BUILD_FAILED. If expected, add mesa:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt. ``` -- Downloading https://gitlab.freedesktop.org/mesa/mesa/-/archive/mesa-21.2.5/mesa-mesa-21.2.5.tar.gz -> mesa-mesa-mesa-21.2.5-1.tar.gz... -- Extracting source /Users/vagrant/Data/downloads/mesa-mesa-mesa-21.2.5-1.tar.gz -- Applying patch swravx512-post-static-link.patch -- Applying patch swr-msvc-2.patch -- Applying patch swr-llvm13.patch -- Applying patch radv-msvc-llvm13-2.patch -- Applying patch d3d10sw.patch -- Using source at /Users/vagrant/Data/buildtrees/mesa/src/esa-21.2.5-2df234d2b1.clean Traceback (most recent call last): File "<string>", line 1, in <module> ModuleNotFoundError: No module named 'mako' CMake Error at ports/mesa/portfile.cmake:85 (message): Python package 'mako' needs to be installed for port 'mesa'. Complete list of required python packages: setuptools;mako Call Stack (most recent call first): ports/mesa/portfile.cmake:91 (vcpkg_get_python_package) scripts/ports.cmake:145 (include) ``` Looks like this is being tracked by #23089 ; perhaps that we don't have as aggressive a recycling strategy for macos boxes as we do for the others has let different machines give different results? ## Only broken without tool update: REGRESSION: chromium-base:x64-osx. If expected, add chromium-base:x64-osx=fail to .\scripts\ci.baseline.txt. This one has been constantly flaky; I baselined it. REGRESSION: libxml2:x64-osx. If expected, add libxml2:x64-osx=fail to .\scripts\ci.baseline.txt. This port uses vcpkg_from_git and the upstream server was down during the build. * Restore chartdir to the baseline, I thought #23732 had been merged.

strega-nil-ms · 2022-03-28T20:20:40Z

This looks good to me; running CI here: https://dev.azure.com/vcpkg/public/_build/results?buildId=69542&view=results

dg0yt · 2022-03-28T21:18:16Z

scripts/buildsystems/vcpkg.cmake

    list(REMOVE_ITEM Z_VCPKG_TOOLS_DIRS ${Z_VCPKG_TOOLS_FILES} "") # need at least one item for REMOVE_ITEM if CMake <= 3.19
-    list(FILTER Z_VCPKG_TOOLS_DIRS EXCLUDE REGEX "/debug/")
+    list(REMOVE_ITEM Z_VCPKG_TOOLS_DIRS_BIN ${Z_VCPKG_TOOLS_FILES_BIN} "")
+    string(REPLACE "/bin" "" Z_VCPKG_TOOLS_DIRS_TO_REMOVE "${Z_VCPKG_TOOLS_DIRS_BIN}")


Note that there are some ports which have programs in both tools/pkg and tools/pkg/bin.
Example: curl[tool]. (Still waiting for tool filesystem layout spec.)

Seems like a inconsistency in the curl port.
Also this port indirectly mandates a certain layout.
It is either /tools/*/bin or /tools/* what * is up to the portfile to decide

a) It wasn't an issue before the change we need to fix now. tools/<Pkg>/bin was not in the search path.
b) I asked about tool file system layout almost one year ago, and other issues are open even longer.
c) curl is illustrative because it has curl the well-known general tool, and curl-config, the script which provides configuration information for either release or debug.

Neumann-A · 2022-03-29T12:44:48Z

This looks good to me; running CI here: https://dev.azure.com/vcpkg/public/_build/results?buildId=69542&view=results

I am a bit concerned that the run only took around 13h and that i see:

    vcpkg-ci-ffmpeg:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: 180.2 us
    vcpkg-ci-opencv:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: 557.7 us

strega-nil-ms · 2022-03-29T17:58:09Z

@Neumann-A this is because our massive builds (tensorflow) are broken with VS2022; until they're working again our builds don't take very long.

Compared to the most recent CI build, this only fixes stuff, so I'm comfortable merging (qtinterfaceframework is failing now but it was cascaded before)

strega-nil-ms · 2022-03-29T18:07:14Z

--- 
+++ 
@@ -318,18 +318,16 @@
     cgicc:x64-windows: SUCCEEDED: <time>
     cgl:x64-windows: SUCCEEDED: <time>
     cgltf:x64-windows: SUCCEEDED: <time>
     cgns:x64-windows: SUCCEEDED: <time>
     chaiscript:x64-windows: SUCCEEDED: <time>
     chakracore:x64-windows: SUCCEEDED: <time>
-    chartdir:x64-windows: SUCCEEDED: <time>
     check:x64-windows: SUCCEEDED: <time>
     chipmunk:x64-windows: SUCCEEDED: <time>
     chmlib:x64-windows: SUCCEEDED: <time>
     chromaprint:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    chromium-base:x64-windows: BUILD_FAILED: <time>
     cimg:x64-windows: SUCCEEDED: <time>
     cityhash:x64-windows: SUCCEEDED: <time>
     civetweb:x64-windows: SUCCEEDED: <time>
     cjson:x64-windows: SUCCEEDED: <time>
     clamav:x64-windows: SUCCEEDED: <time>
     clara:x64-windows: SUCCEEDED: <time>
@@ -1345,50 +1343,50 @@
     qt5-websockets:x64-windows: SUCCEEDED: <time>
     qt5-webview:x64-windows: SUCCEEDED: <time>
     qt5-winextras:x64-windows: SUCCEEDED: <time>
     qt5-x11extras:x64-windows: POST_BUILD_CHECKS_FAILED: <time>
     qt5-xmlpatterns:x64-windows: SUCCEEDED: <time>
     qt5:x64-windows: SUCCEEDED: <time>
-    qt5compat:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qt5compat:x64-windows: SUCCEEDED: <time>
     qt:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtactiveqt:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtapplicationmanager:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qtactiveqt:x64-windows: SUCCEEDED: <time>
+    qtapplicationmanager:x64-windows: SUCCEEDED: <time>
     qtbase:x64-windows: SUCCEEDED: <time>
-    qtcharts:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qtcharts:x64-windows: SUCCEEDED: <time>
     qtcoap:x64-windows: SUCCEEDED: <time>
     qtconnectivity:x64-windows: SUCCEEDED: <time>
-    qtdatavis3d:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtdeclarative:x64-windows: BUILD_FAILED: <time>
+    qtdatavis3d:x64-windows: SUCCEEDED: <time>
+    qtdeclarative:x64-windows: SUCCEEDED: <time>
     qtdoc:x64-windows: SUCCEEDED: <time>
     qtimageformats:x64-windows: SUCCEEDED: <time>
-    qtinterfaceframework:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtkeychain-qt6:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qtinterfaceframework:x64-windows: BUILD_FAILED: <time>
+    qtkeychain-qt6:x64-windows: SUCCEEDED: <time>
     qtkeychain:x64-windows: SUCCEEDED: <time>
-    qtlocation:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtlottie:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qtlocation:x64-windows: SUCCEEDED: <time>
+    qtlottie:x64-windows: SUCCEEDED: <time>
     qtmqtt:x64-windows: SUCCEEDED: <time>
-    qtmultimedia:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qtmultimedia:x64-windows: SUCCEEDED: <time>
     qtnetworkauth:x64-windows: SUCCEEDED: <time>
-    qtopcua:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtpositioning:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtquick3d:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtquickcontrols2:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtquicktimeline:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtremoteobjects:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtscxml:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtsensors:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qtopcua:x64-windows: SUCCEEDED: <time>
+    qtpositioning:x64-windows: SUCCEEDED: <time>
+    qtquick3d:x64-windows: SUCCEEDED: <time>
+    qtquickcontrols2:x64-windows: SUCCEEDED: <time>
+    qtquicktimeline:x64-windows: SUCCEEDED: <time>
+    qtremoteobjects:x64-windows: SUCCEEDED: <time>
+    qtscxml:x64-windows: SUCCEEDED: <time>
+    qtsensors:x64-windows: SUCCEEDED: <time>
     qtserialbus:x64-windows: SUCCEEDED: <time>
     qtserialport:x64-windows: SUCCEEDED: <time>
     qtshadertools:x64-windows: SUCCEEDED: <time>
     qtsvg:x64-windows: SUCCEEDED: <time>
-    qttools:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qttranslations:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtvirtualkeyboard:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtwebchannel:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtwebengine:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
-    qtwebsockets:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
+    qttools:x64-windows: SUCCEEDED: <time>
+    qttranslations:x64-windows: SUCCEEDED: <time>
+    qtvirtualkeyboard:x64-windows: SUCCEEDED: <time>
+    qtwebchannel:x64-windows: SUCCEEDED: <time>
+    qtwebengine:x64-windows: BUILD_FAILED: <time>
+    qtwebsockets:x64-windows: SUCCEEDED: <time>
     qtwebview:x64-windows: CASCADED_DUE_TO_MISSING_DEPENDENCIES: <time>
     quadtree:x64-windows: SUCCEEDED: <time>
     quaternions:x64-windows: SUCCEEDED: <time>
     quazip:x64-windows: SUCCEEDED: <time>
     quickfast:x64-windows: SUCCEEDED: <time>
     quickfix:x64-windows: BUILD_FAILED: <time>
@@ -1739,13 +1737,12 @@
     wordnet:x64-windows: SUCCEEDED: <time>
     workflow:x64-windows: SUCCEEDED: <time>
     wpilib:x64-windows: SUCCEEDED: <time>
     wren:x64-windows: SUCCEEDED: <time>
     wt:x64-windows: SUCCEEDED: <time>
     wtl:x64-windows: SUCCEEDED: <time>
-    wxchartdir:x64-windows: SUCCEEDED: <time>
     wxwidgets:x64-windows: SUCCEEDED: <time>
     x-plane:x64-windows: SUCCEEDED: <time>
     x264:x64-windows: SUCCEEDED: <time>
     x265:x64-windows: SUCCEEDED: <time>
     xalan-c:x64-windows: SUCCEEDED: <time>
     xaudio2redist:x64-windows: SUCCEEDED: <time>
@@ -1794,18 +1791,17 @@
     zug:x64-windows: SUCCEEDED: <time>
     zydis:x64-windows: SUCCEEDED: <time>
     zyre:x64-windows: SUCCEEDED: <time>
     zziplib:x64-windows: SUCCEEDED: <time>
 
 SUMMARY FOR x64-windows
-    SUCCEEDED: 1731
+    SUCCEEDED: 1752
     BUILD_FAILED: 17
     POST_BUILD_CHECKS_FAILED: 1
     FILE_CONFLICTS: 0
-    CASCADED_DUE_TO_MISSING_DEPENDENCIES: 47
+    CASCADED_DUE_TO_MISSING_DEPENDENCIES: 23
     EXCLUDED: 0
     CACHE_MISSING: 0
     DOWNLOADED: 0
-##[error]REGRESSION: qtdeclarative:x64-windows. If expected, add qtdeclarative:x64-windows=fail to .\scripts\ci.baseline.txt.
-PASSING, REMOVE FROM FAIL LIST: chartdir:x64-windows (.\scripts\ci.baseline.txt)
+##[error]REGRESSION: qtinterfaceframework:x64-windows failed with BUILD_FAILED. If expected, add qtinterfaceframework:x64-windows=fail to C:\a\2\s\scripts\azure-pipelines/../ci.baseline.txt.
 
 ##[section]Finishing: *** Test Modified Ports for x64-windows

BillyONeal · 2022-03-29T18:34:35Z

Compared to the most recent CI build, this only fixes stuff, so I'm comfortable merging (qtinterfaceframework is failing now but it was cascaded before)

I agree but we need to figure out why the "ci" ports are failing ASAP.

Neumann-A · 2022-03-29T18:37:17Z

@BillyONeal I feel like you don't have vcpkg on watch all ;) Isn't that riddle (failing:qtinterfaceframework) not already solved by #23766 (comment)

BillyONeal · 2022-03-29T19:02:14Z

@BillyONeal I feel like you don't have vcpkg on watch all ;) Isn't that riddle (failing:qtinterfaceframework) not already solved by #23766 (comment)

I do not, I don't understand how anyone can keep up with that fire hose

BillyONeal · 2022-03-29T19:02:56Z

@BillyONeal I feel like you don't have vcpkg on watch all ;) Isn't that riddle (failing:qtinterfaceframework) not already solved by #23766 (comment)

(Also by 'ci ports' I mean vcpkg-ci-Xxx not qtinterfaceframework)

strega-nil-ms · 2022-03-29T20:46:41Z

#23857 should fix this issue.

strega-nil-ms · 2022-03-30T00:12:10Z

Given that this makes the world better, and the ci port weirdness is being fixed, I'm merging.

Neumann-A added 2 commits March 24, 2022 23:57

more filtering of tool paths.

263cdff

test it in CI

4e094c6

github-actions bot requested changes Mar 24, 2022

View reviewed changes

Neumann-A mentioned this pull request Mar 24, 2022

Qt components may fail to build when there are too many files in installed/*/tools directory #23746

Closed

JonLiu1993 assigned JackBoosY Mar 25, 2022

JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Mar 25, 2022

Neumann-A added 2 commits March 26, 2022 23:17

only use tools/* and tools/*/bin

876fadc

debugging

58fc158

github-actions bot requested changes Mar 26, 2022

View reviewed changes

dg0yt reviewed Mar 27, 2022

View reviewed changes

scripts/buildsystems/vcpkg.cmake Outdated Show resolved Hide resolved

Neumann-A added 2 commits March 28, 2022 21:07

Merge remote-tracking branch 'upstream/master' into dont_clober_cmake…

f2f88b6

…_program_path

test removal of tools/* if tools/*/bin is available

0049b64

github-actions bot requested changes Mar 28, 2022

View reviewed changes

Neumann-A mentioned this pull request Mar 28, 2022

[qt-declarative] CI build failure on x64-windows #23824

Closed

fix variable naming

f0a6e28

github-actions bot requested changes Mar 28, 2022

View reviewed changes

cleanup

3e941d6

Neumann-A commented Mar 28, 2022

View reviewed changes

ports/qtdeclarative/portfile.cmake Outdated Show resolved Hide resolved

github-actions bot requested changes Mar 28, 2022

View reviewed changes

revert ports/qtdeclarative/portfile.cmake

9101338

Neumann-A marked this pull request as ready for review March 28, 2022 19:56

github-actions bot approved these changes Mar 28, 2022

View reviewed changes

BillyONeal mentioned this pull request Mar 28, 2022

Update vcpkg-tool to 2022-03-25 #23757

Merged

vicroms approved these changes Mar 28, 2022

View reviewed changes

dg0yt reviewed Mar 28, 2022

View reviewed changes

BillyONeal mentioned this pull request Mar 29, 2022

[cmake-user] Verify library location for debug vs. release, fix ports #21641

Merged

strega-nil-ms merged commit 16ebf7b into microsoft:master Mar 30, 2022

Neumann-A deleted the dont_clober_cmake_program_path branch March 30, 2022 05:55

Conversation

Neumann-A commented Mar 24, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

dg0yt commented Mar 25, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms commented Mar 28, 2022

Uh oh!

dg0yt Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

Neumann-A Mar 29, 2022

Choose a reason for hiding this comment

Uh oh!

dg0yt Mar 29, 2022

Choose a reason for hiding this comment

Uh oh!

Neumann-A commented Mar 29, 2022

Uh oh!

strega-nil-ms commented Mar 29, 2022

Uh oh!

strega-nil-ms commented Mar 29, 2022

Uh oh!

BillyONeal commented Mar 29, 2022

Uh oh!

Neumann-A commented Mar 29, 2022

Uh oh!

BillyONeal commented Mar 29, 2022

Uh oh!

BillyONeal commented Mar 29, 2022

Uh oh!

strega-nil-ms commented Mar 29, 2022

Uh oh!

strega-nil-ms commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants