[tbb] fix tbb by updating it by Neumann-A · Pull Request #23567 · microsoft/vcpkg

Neumann-A · 2022-03-15T15:23:38Z

No description provided.

mathisloge · 2022-03-15T16:17:22Z

related #19909 and #23058

Neumann-A · 2022-03-16T21:57:45Z

ports/gazebo/portfile.cmake

+    REF ea956014ed45906dda21e1ee682d297189cb4a7b
    SHA512 57638cd0b23b5f2bfd32fdc159d6cd77ca34e3bd695c225591979aef4b7271eac93d3706fa1ffa2340f90013267a4171bebe1e4c142f19ad2bf67963dfed627e


Hmm why isn't CI choking on this? Is the hash check broken somehow? cc @BillyONeal @strega-nil

JackBoosY · 2022-03-17T03:07:27Z

See why tbb is not updated in #16321.

Neumann-A · 2022-03-17T07:17:37Z

@JackBoosY: the only one blocking this is the usd port and ras0219 put in on the skip list in #19909

Neumann-A · 2022-03-17T07:25:41Z

Gazebo error:

D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(58): error C2516: 'tbb::v1::task': is not a legal base class
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(73): error C2143: syntax error: missing ';' before '*'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(73): error C2886: 'tbb::v1::task': symbol cannot be used in a member using-declaration
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(74): error C2334: unexpected token(s) preceding '{'; skipping apparent function body
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(313): error C2039: 'allocate_root': is not a member of 'tbb::v1::task'
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(294): note: This diagnostic occurred in the compiler generated function 'void gazebo::transport::Connection::OnReadData(const boost::system::error_code &,boost::tuples::tuple<Handler,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type>)'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(315): error C2039: 'enqueue': is not a member of 'tbb::v1::task'
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo\transport\Connection.hh(294): note: This diagnostic occurred in the compiler generated function 'void gazebo::transport::Connection::OnReadData(const boost::system::error_code &,boost::tuples::tuple<Handler,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type,boost::tuples::null_type>)'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(40): error C2516: 'tbb::v1::task': is not a legal base class
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(54): error C2143: syntax error: missing ';' before '*'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(54): error C2886: 'tbb::v1::task': symbol cannot be used in a member using-declaration
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(55): error C2334: unexpected token(s) preceding '{'; skipping apparent function body
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(162): error C2039: 'allocate_root': is not a member of 'tbb::v1::task'
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(158): note: This diagnostic occurred in the compiler generated function 'void gazebo::transport::Node::Publish(const std::string &,const google::protobuf::Message &)'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(165): error C2039: 'enqueue': is not a member of 'tbb::v1::task'
D:\installed\x86-windows\include\tbb\../oneapi/tbb/task.h(26): note: see declaration of 'tbb::v1::task'
D:\buildtrees\gazebo\src\7189cb4a7b-e170e5c60c.clean\gazebo/transport/Node.hh(158): note: This diagnostic occurred in the compiler generated function 'void gazebo::transport::Node::Publish(const std::string &,const google::protobuf::Message &)'

Neumann-A · 2022-03-17T07:29:25Z

pagmo2 error:

FAILED: CMakeFiles/pagmo.dir/src/algorithms/mbh.cpp.obj 
D:\installed\x86-windows\include\boost/mpl/print.hpp(55): error C2220: the following warning is treated as an error
... long template chain
D:\installed\x86-windows\include\boost/mpl/print.hpp(55): warning C4308: negative integral constant converted to unsigned type

JackBoosY · 2022-03-17T08:23:22Z

Can I help you to fix these regressions?

Neumann-A · 2022-03-17T08:27:46Z

Can I help you to fix these regressions?

@JackBoosY: You can try. I won't be able to do anything here until the weekend probably,.

Thomas1664 · 2022-04-14T17:05:45Z

pagmo2 error:

FAILED: CMakeFiles/pagmo.dir/src/algorithms/mbh.cpp.obj 
D:\installed\x86-windows\include\boost/mpl/print.hpp(55): error C2220: the following warning is treated as an error
... long template chain
D:\installed\x86-windows\include\boost/mpl/print.hpp(55): warning C4308: negative integral constant converted to unsigned type

This can be fixed by patching out -Werror or /WX

Tradias · 2022-04-26T12:54:23Z

I already wrote the -Werror patch in ras0219-msft's pull request: #19909 (comment)

JackBoosY · 2022-07-15T05:50:12Z

~~Any progress here?~~ Ignore me.

Neumann-A · 2022-09-18T20:26:38Z

superseded by #26284

Alexander Neumann added 2 commits March 15, 2022 16:22

update tbb

d382265

version stuff

45b9cd7

Neumann-A marked this pull request as draft March 15, 2022 21:39

Neumann-A added 7 commits March 15, 2022 23:22

wip commit

38165d2

only activate sse42 by default

76f1cfd

fix tbb config

14698b9

fix hash

634e18f

fix embree configure?

cf5d4cc

move files

779bbff

skip usd

f9e5b02

Adela0814 assigned JackBoosY Mar 16, 2022

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 16, 2022

Neumann-A added 10 commits March 16, 2022 21:27

Merge remote-tracking branch 'upstream/master' into fix_tbb_linux

229ea0a

fix pagmo2 build

0ce2175

deprecate embree2

72ad854

format manifest

c258286

maybe fix gazebo?

dc71dc9

move gazebo in date instead of patching

ae2433a

forgot to save

81e6aff

skip embree2 in ci

fec80ac

remove head ref

90434b7

version stuff

0c169de

Neumann-A commented Mar 16, 2022

View reviewed changes

vicroms mentioned this pull request Mar 16, 2022

Update VMs for VS2022, CUDA 11.6 #23011

Merged

JackBoosY mentioned this pull request Mar 17, 2022

[vcpkg baseline][tbb] Disable binary mismatch checking #23608

Merged

JonLiu1993 mentioned this pull request Mar 18, 2022

[tbb] Update to 2021.3.0 #19909

Closed

JackBoosY changed the title ~~[baseline] fix tbb by updating it~~ [tbb] fix tbb by updating it Mar 21, 2022

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 15, 2022

JulianGro mentioned this pull request Jul 26, 2022

Update tbb to fix building on Apple M1 overte-org/overte#136

Closed

Neumann-A closed this Sep 18, 2022

BillyONeal mentioned this pull request Sep 19, 2022

[tbb, pagmo2] Update TBB to 2021.5 and update pagmo2 to 2.18.0 #26284

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tbb] fix tbb by updating it#23567

[tbb] fix tbb by updating it#23567
Neumann-A wants to merge 19 commits intomicrosoft:masterfrom
Neumann-A:fix_tbb_linux

Neumann-A commented Mar 15, 2022

Uh oh!

mathisloge commented Mar 15, 2022

Uh oh!

Neumann-A Mar 16, 2022

Uh oh!

JackBoosY commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

JackBoosY commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

Thomas1664 commented Apr 14, 2022

Uh oh!

Tradias commented Apr 26, 2022

Uh oh!

JackBoosY commented Jul 15, 2022 •

edited

Loading

Uh oh!

Neumann-A commented Sep 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		REF ea956014ed45906dda21e1ee682d297189cb4a7b
		SHA512 57638cd0b23b5f2bfd32fdc159d6cd77ca34e3bd695c225591979aef4b7271eac93d3706fa1ffa2340f90013267a4171bebe1e4c142f19ad2bf67963dfed627e

Conversation

Neumann-A commented Mar 15, 2022

Uh oh!

mathisloge commented Mar 15, 2022

Uh oh!

Neumann-A Mar 16, 2022

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

JackBoosY commented Mar 17, 2022

Uh oh!

Neumann-A commented Mar 17, 2022

Uh oh!

Thomas1664 commented Apr 14, 2022

Uh oh!

Tradias commented Apr 26, 2022

Uh oh!

JackBoosY commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Sep 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JackBoosY commented Jul 15, 2022 •

edited

Loading