Skip to content

[tbb] Update to 2021.1.1 to use official cmake build method#16321

Closed
JackBoosY wants to merge 14 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16308
Closed

[tbb] Update to 2021.1.1 to use official cmake build method#16321
JackBoosY wants to merge 14 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16308

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

Since the upstream supported the official cmake build method, always use that to build tbb.

Fixes #16308.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal category:port-update The issue is with a library, which is requesting update new revision labels Feb 20, 2021
@Chronial
Copy link
Copy Markdown
Contributor

Wow, that was quick. Thanks for working on this ❤️

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Feb 24, 2021

Regression list:

linux:

  • embree3:x64-linux
  • usd:x64-linux
  • openvdb:x64-linux
  • pagmo2:x64-linux
  • parallelstl:x64-linux

osx:

  • embree3:x64-osx
  • usd:x64-osx
  • openvdb:x64-osx
  • pagmo2:x64-osx
  • parallelstl:x64-osx

x64-windows:

  • usd:x64-windows
  • pagmo2:x64-windows
  • embree2:x64-windows
  • embree3:x64-windows
  • openvdb:x64-windows

x64-windows-static:

  • openvdb:x64-windows-static
  • pagmo2:x64-windows-static
  • embree3:x64-windows-static
  • parallelstl:x64-windows-static
  • usd:x64-windows-static

x64-windows-static-md:

  • openvdb:x64-windows-static-md
  • parallelstl:x64-windows-static-md
  • embree3:x64-windows-static-md
  • usd:x64-windows-static-md
  • pagmo2:x64-windows-static-md

x86-windows:

  • embree3:x86-windows
  • openvdb:x86-windows
  • pagmo2:x86-windows
  • embree2:x86-windows

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Feb 24, 2021

embree2:

F:\vcpkg\buildtrees\embree2\src\v2.17.7-7b6559a4fb.clean\common\tasking\taskschedulertbb.cpp(22): error C2039: 'task_scheduler_init': is not a member of 'tbb'

Shoud update embree2.

embree3:

f:\vcpkg\buildtrees\embree3\src\v3.11.0-eab186fec2.clean\common\algorithms\parallel_reduce.h(59): error C2039: 'self': is not a member of 'tbb::v1::task'

Shoud also update embree3.

openvdb:

f:\vcpkg\buildtrees\openvdb\src\4d84956ff7-b331bacb74\openvdb\tree\LeafBuffer.h(10): fatal error C1083: Cannot open include file: 'tbb/atomic.h': No such file or directory

Also should update it, this header doesn't exist now.

pagmo2:
After remove file ${SOURCE_PATH}/cmake_modules/FindTBB.cmake, I got error:

f:\vcpkg\installed\x86-windows\include\oneapi\tbb\detail/_task.h(233): error C2220: warning treated as error - no 'object' file generated
f:\vcpkg\installed\x86-windows\include\oneapi\tbb\detail/_task.h(233): warning C4324: 'tbb::detail::d1::task': structure was padded due to alignment specifier

Discussion in the upstream uxlfoundation/oneTBB#272.

parallelstl:
configure error. Fixed.

usd:

F:\vcpkg\buildtrees\usd\x64-windows-static-dbg\include\pxr/base/tf/pch.h(246): fatal error C1083: Cannot open include file: 'tbb/atomic.h': No such file or directory

Same with openvdb, needs update version.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Mar 3, 2021

The openvdb upstream doesn't support this version of tbb, I already open a new issue to the upstream (AcademySoftwareFoundation/openvdb#985).

Same with usd, upstream issue PixarAnimationStudios/OpenUSD#1471.
Same with pagmo2, upstream issue esa/pagmo2#468.

@longnguyen2004
Copy link
Copy Markdown
Contributor

How is this PR going?

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@longnguyen2004 Since some upstreams doesn't reply or fix this issue, waiting for official response.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

Waiting for upstream support.

@JackBoosY JackBoosY closed this Jun 7, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

Needs wait for openvdb next version over 8.1.0.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

Waiting for USD support latest tbb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision depends:upstream-changes Waiting on a change to the upstream project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tbb] Does not build a debug lib on linux static

4 participants