Skip to content

[arrow] Fix CMake link error#22387

Merged
strega-nil-ms merged 4 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/issue20459
Jan 7, 2022
Merged

[arrow] Fix CMake link error#22387
strega-nil-ms merged 4 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/issue20459

Conversation

@LilyWangLL
Copy link
Copy Markdown
Contributor

@LilyWangLL LilyWangLL commented Jan 6, 2022

Fixes #20459 Fixes #18538

  1. Modify find_package(arrow CONFIG REQUIRED) to find_package(Arrow CONFIG REQUIRED), fix CMake configuage error on Linux:
CMake Warning at /home/vlilywang/Lily/vcpkg/installed/x64-linux/share/arrow/arrow-config.cmake:18 (message):
  find_package(arrow) is deprecated.  Use find_package(Arrow) instead.
Call Stack (most recent call first):
  /home/vlilywang/Lily/vcpkg/installed/x64-linux/share/arrow/vcpkg-cmake-wrapper.cmake:1 (_find_package)
  /home/vlilywang/Lily/vcpkg/scripts/buildsystems/vcpkg.cmake:742 (include)
  CMakeLists.txt:5 (find_package)

-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Found OpenSSL: /home/vlilywang/Lily/vcpkg/installed/x64-linux/debug/lib/libcrypto.a (found version "1.1.1l")
-- Found thrift: /home/vlilywang/Lily/vcpkg/installed/x64-linux
-- Found ZLIB: /home/vlilywang/Lily/vcpkg/installed/x64-linux/lib/libz.a (found version "1.2.11")
-- Found BZip2: /home/vlilywang/Lily/vcpkg/installed/x64-linux/lib/libbz2.a (found version "1.0.8")
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - found
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find arrow (missing: ARROW_INCLUDE_DIR) (found version "6.0.1")
  1. Fix CMake build error as below, install the files *config.cmake and *target.cmake of parquet to correct directory. Remove link libraries arrow_bundled_dependencies, because this is the dependencies of arrow, VCPKG will find these dependencies which installing by VCPKG.
/usr/bin/ld: cannot find -lparquet_static
/usr/bin/ld: cannot find -larrow_bundled_dependencies

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jan 6, 2022
@LilyWangLL LilyWangLL requested a review from JackBoosY January 6, 2022 09:43
JackBoosY
JackBoosY suggested changes Jan 6, 2022
View reviewed changes
@LilyWangLL LilyWangLL marked this pull request as ready for review January 6, 2022 12:00
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 7, 2022
@strega-nil-ms
Copy link
Copy Markdown
Contributor

strega-nil-ms commented Jan 7, 2022

LGTM, thanks Lily!

@strega-nil-ms strega-nil-ms merged commit 6d27dc9 into microsoft:master Jan 7, 2022
rhuijben pushed a commit to rhuijben/vcpkg that referenced this pull request Jan 25, 2022
@LilyWangLL @rhuijben
[arrow] Fix CMake link error (microsoft#22387)
378a018 
* [arrow] Fix CMake link error

* update version

* [arrow] update vcpkg-cmake-wrapper.cmake

* update version

Co-authored-by: Lily Wang <v-lilywang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Arrow link error after installing on Ubuntu [arrow] CMake Linker Usage?

3 participants

@LilyWangLL @strega-nil-ms @JackBoosY