[vcpkg_fixup_pkgconfig] HOTFIX -- revert #19469#19607
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Aug 17, 2021
Merged
[vcpkg_fixup_pkgconfig] HOTFIX -- revert #19469#19607ras0219-msft merged 1 commit intomicrosoft:masterfrom
ras0219-msft merged 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
Bypassing full CI check because this is a revert back to a known good state. I've manually reviewed the changes in #19469 to ensure that this file can be independently rolled back. |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Aug 17, 2021
[vcpkg_fixup_pkgconfig] HOTFIX -- revert microsoft#19469 (microsoft#19607)
Contributor
|
Thanks for the quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #19469 regressed pkgconfig for libcurl. This was not detected because it also regressed the self-check mechanism (removed argument from
vcpkg_fixup_pkgconfig_check_fileswithout removing the argument from the callers).Because there are a large number of changes in the helper and the internal consistency check was disabled, I'm reverting the entire change so it can go through a proper separate PR process again.
Fixes #19606