Closed
Conversation
This fixes X_VCPKG_APPLOCAL_DEPS_INSTALL when the install() command has a DESTINATION argument.
ras0219-msft
approved these changes
Jul 26, 2021
strega-nil-ms
approved these changes
Jul 26, 2021
JackBoosY
approved these changes
Jul 27, 2021
Merged
Contributor
|
Closed for rollup; thanks @Hoikas ! |
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Jul 28, 2021
[vcpkg.cmake] Fix variable case.
strega-nil-ms
added a commit
that referenced
this pull request
Jul 29, 2021
* [rollup:2021-07-26 1/6] PR #18783 (@strega-nil) [scripts-audit] vcpkg_copy_tools and friends * [rollup:2021-07-26 2/6] PR #18898 (@dg0yt) [vcpkg] Fix toolchain compatibility with cmake < 3.15 * [rollup:2021-07-26 3/6] PR #18980 (@strega-nil) [cmake-guidelines] Minor update, for `if()` * [rollup:2021-07-26 4/6] PR #18981 (@strega-nil) [scripts-audit] vcpkg_check_linkage * [rollup:2021-07-26 5/6] PR #19158 (@Hoikas) [vcpkg.cmake] Fix variable case. * [rollup:2021-07-26 6/6] PR #18839 [scripts-audit] z_vcpkg_get_cmake_vars Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes X_VCPKG_APPLOCAL_DEPS_INSTALL when the install() command has a DESTINATION argument.
What does your PR fix?
Fixes X_VCPKG_APPLOCAL_DEPS_INSTALL Regression #19123
Which triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?No ports changed.