[scripts-audit] vcpkg_fail_port_install#18054
Closed
strega-nil wants to merge 1 commit intomicrosoft:masterfrom
Closed
[scripts-audit] vcpkg_fail_port_install#18054strega-nil wants to merge 1 commit intomicrosoft:masterfrom
strega-nil wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Note that this change allows existing failures; it changes MATCHES to STREQUAL, meaning that vcpkg_fail_port_install(ON_ARCH "arm") now succeeds on arm64; this change in behavior is fine (IMO) since it strictly succeeds when it used to fail.
Contributor
|
Marking requires:discussion since this is a change in behaviour. |
Contributor
|
just deprecate the script. It was just created because there was no supports field. |
Contributor
Author
|
@Neumann-A sure, that is also a thing I'd like for us to do. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 25, 2021
Note that this change allows existing failures; it changes MATCHES to STREQUAL, meaning that vcpkg_fail_port_install(ON_ARCH "arm") now succeeds on arm64; this change in behavior is fine (IMO) since it strictly succeeds when it used to fail.
Contributor
Author
|
Closing for rollup (#18112) |
strega-nil-ms
pushed a commit
that referenced
this pull request
May 26, 2021
* [scripts-audit] vcpkg_acquire_msys (#17687) * [vcpkg.cmake] Change find_package function -> macro in order to shorten trace (#17997) switch from function to macro * [scripts-audit] z_vcpkg_apply_patches (#18013) * [scripts-audit] z_vcpkg_escape_regex_control_characters (#18013) * [scripts-audit] vcpkg_fail_port_install (#18054) Note that this change allows existing failures; it changes MATCHES to STREQUAL, meaning that vcpkg_fail_port_install(ON_ARCH "arm") now succeeds on arm64; this change in behavior is fine (IMO) since it strictly succeeds when it used to fail.
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this change allows existing failures;
it changes MATCHES to STREQUAL, meaning that
vcpkg_fail_port_install(ON_ARCH "arm") now succeeds on arm64;
this change in behavior is fine (IMO) since it strictly succeeds
when it used to fail.