[libvpx] Fix libvpx compilation (install process)#17287
[libvpx] Fix libvpx compilation (install process)#17287strega-nil merged 9 commits intomicrosoft:masterfrom
Conversation
Can you double confirm your changes? |
Is it from your pc? Both computers running windows 10. |
|
@talregev From our pipeline test, Windows10 with Visual Studio 2019. |
|
@talregev What triplet do you use? |
|
both x86-windows x64-windows |
|
I haven't seen this happen on my CI (with x64-windows, x64-windows-static, and x64-windows-static-md); installation and compilation works fine. For the record, logs are here (for an ffmpeg master build, but otherwise the portfiles are the same, and in particular its the same for libvpx): https://ci.appveyor.com/project/mcmtroffaes/ffmpeg-msvc-build/build/job/3yn0l4c3ge9fwkiy (x64-windows) This seems vaguely related to #12706 where the names were fixed to ensure the pdb files were found when compiling other apps against ffmpeg: the pdb files cannot be renamed after install. |
I think it a good lead and I would start from there. Did you / ci try to compile |
|
I think CRT linkage affected it. |
That's a good suggestion. I just tested |
|
@JackBoosY |
|
Maybe the problem is from the things I install on visual studio. like mfc and clang support? |
|
@JackBoosY any news? |
|
@talregev Nope. |
|
@talregev Can you test whether my changes is correct? |
|
Thanks @JackBoosY! For the record, I've just tested this pr by compiling an application against |
|
LGTM! Thanks @talregev |
|
Unfortunately it doesn't look like this fixed it, in #17331 with this change applied we still see: |
|
I think I have a fix, will put into the VM update PR |
|
A user of my project is reporting this same failure even after this PR. Edit: a manual cherry-pick of 91542464a564bfad42fcf2fa2fbafa3cab929a54 seems to have fixed it |
|
I've started hitting this now as well on appveyor CI (not locally); 9154246 also fixed it for me. Perhaps something to do with the version of Visual Studio. |
|
This issue is now being tripped on GitHub Actions CI. Is there any chance the fix can be fast-tracked @BillyONeal? |
The VM update just landed, try again? |
|
That seems to have fixed it, thanks! |
|
@Hoikas @mcmtroffaes Fixed. |
|
Yup, happy to confirm the fix in master now. Thanks a bunch! |
Fix libvpx compilation (install process)
compile on windows (x86, x64)
Fix Cannot find pdb (line 104 in profile).