Merged
Conversation
The name of the pdb file is always hardcoded in the lib file. The cmake script was renaming the pdb files causing them not to be found. This patch fixes that problem, reverting back to using the upstream pdb file names.
NancyLi1013
approved these changes
Aug 4, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Thanks for the review and the merge! |
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
The name of the pdb file is always hardcoded in the lib file. The cmake script was renaming the pdb files causing them not to be found. This patch fixes that problem, reverting back to using the upstream pdb file names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of the pdb file is always hardcoded in the lib file. The cmake script was renaming the pdb files causing them not to be found (for example, see log messages on this build: https://ci.appveyor.com/project/mcmtroffaes/gta5-simple-video-export/builds/34408763#L224). This patch fixes that problem, reverting back to using the upstream pdb file names.
What does your PR fix? See above.
Which triplets are supported/not supported? Have you updated the CI baseline? Set of supported triplets unchanged.
Does your PR follow the maintainer guide? Yes, to the best of my knowledge.