Skip to content

[xnnpack] create a new port#17064

Merged
dan-shaw merged 29 commits intomicrosoft:masterfrom
luncliff:port/xnnpack
May 18, 2021
Merged

[xnnpack] create a new port#17064
dan-shaw merged 29 commits intomicrosoft:masterfrom
luncliff:port/xnnpack

Conversation

@luncliff
Copy link
Copy Markdown
Contributor

@luncliff luncliff commented Apr 3, 2021 •
edited
Loading

What does your PR fix?

There was no port request for this project. The PR requires #17063.

This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the libtorch port.

Related Works

Which triplets are supported/not supported? Have you updated the CI baseline?

Targets general desktop triplets.

  • x64-osx
  • x64-windows
  • x64-linux

Does your PR follow the maintainer guide?

@luncliff luncliff marked this pull request as draft April 3, 2021 16:17
@luncliff luncliff mentioned this pull request Apr 3, 2021
Merged
@luncliff
Copy link
Copy Markdown
Contributor Author

luncliff commented Apr 3, 2021 •
edited
Loading

in Windows

Requires pthreadpool.lib. It would be better if the port pthreadpool can support find_package.
--> #17196

in Linux

Probably SIMD configuration?

/mnt/vcpkg-ci/buildtrees/xnnpack/src/4927bd2569-2f2aa85dcd.clean/src/qs8-dwconv/gen/up24x9-minmax-sse41-mul32.c:91:50: error: incompatible type for argument 1 of ‘_mm_cvtepi8_epi32’
In file included from /usr/lib/gcc/x86_64-linux-gnu/7/include/immintrin.h:37:0,
                 from /mnt/vcpkg-ci/buildtrees/xnnpack/src/4927bd2569-2f2aa85dcd.clean/src/qs8-dwconv/gen/up24x9-minmax-sse41-mul32.c:12:
/usr/lib/gcc/x86_64-linux-gnu/7/include/smmintrin.h:482:1: note: expected ‘__m128i {aka __vector(2) long long int}’ but argument is of type ‘int’
 _mm_cvtepi8_epi32 (__m128i __X)
 ^~~~~~~~~~~~~~~~~

--> google/XNNPACK#1391

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 5, 2021
luncliff and others added 8 commits April 7, 2021 11:17
@luncliff @JackBoosY
Update ports/cpuinfo/fix-install.patch
6e91ea5 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@luncliff @JackBoosY
Update ports/cpuinfo/fix-install.patch
d8817d8 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@luncliff @JackBoosY
Update ports/cpuinfo/portfile.cmake
fd45b97 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@luncliff @JackBoosY
Update ports/cpuinfo/fix-install.patch
be6c706 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@luncliff
[cpuinfo] update port SHA
8dc3694
@luncliff
[cpuinfo] recover find_package
925dbab 
* fixup target path to `share/unofficial-cpuinfo`
* change IMPORTED target name to `unofficial::cpuinfo::cpuinfo`
@luncliff
[fbgemm] resolve failure after cpuinfo rename
5c3b233 
* change cpuinfo::cpuinfo to unofficial
@luncliff
[fbgemm] update port version
b76d735
@luncliff luncliff mentioned this pull request Apr 10, 2021
Merged
This was referenced Apr 10, 2021
Merged
Merged
@luncliff
Copy link
Copy Markdown
Contributor Author

luncliff commented Apr 10, 2021 •
edited
Loading

Linux

luncliff added 2 commits April 11, 2021 00:36
@luncliff
[xnnpack] update code to latest
e54f5ac 
* change snapshot to resolve linux compile errors
@luncliff
[xnnpack] "supports" in manifest
76cdeb7 
* update baseline & port SHA
@luncliff
Copy link
Copy Markdown
Contributor Author

luncliff commented Apr 10, 2021 •
edited
Loading

This PR will be rebased after these.

@NancyLi1013 NancyLi1013 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 12, 2021
@luncliff luncliff marked this pull request as ready for review May 6, 2021 01:52
@BillyONeal BillyONeal removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 7, 2021
NancyLi1013
NancyLi1013 suggested changes May 7, 2021
View reviewed changes
@luncliff luncliff requested a review from NancyLi1013 May 17, 2021 05:55
@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels May 18, 2021
@dan-shaw dan-shaw merged commit 968c5eb into microsoft:master May 18, 2021
@luncliff luncliff deleted the port/xnnpack branch May 18, 2021 07:26
@luncliff luncliff mentioned this pull request Apr 2, 2022
Merged
@luncliff luncliff mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

+1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luncliff @BillyONeal @NancyLi1013 @JackBoosY @dan-shaw